Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67134

change_password_url() is used for change password for logged-in and not logged-in users

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Deferred
    • Icon: Minor Minor
    • None
    • 3.6.6, 3.7.2, 3.8
    • Authentication
    • MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE

      In MDL-66984, an interim solution has been accepted to flip-flip $USER, until a better API will be created. 

      The main problem here is that the very same method change_password_url() is used both for change password (with the user logged in) and forgot/reset the password (with the user not logged in). There are, at least, 2 different approaches to fix it:

      • Stop relying on $USER and add a $user parameter to it, so it works independently of the logged-in status.
      • Split functions and use a different one for each case.

       
       

            Unassigned Unassigned
            sarjona Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.