Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67137

Polyfills missing for IE DOM

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Behat will cover this for the most part

      1. Smoke test the new forum grader using Internet Exploder 10 or 11.
        • Create a forum with grade type set to point with a value of 100.
        • From the forum view, you'll see a 'grade users' button. Click it to view the new grading interface.
      2. Just make sure you are able to load the view, grade a student, etc.
      Show
      Behat will cover this for the most part Smoke test the new forum grader using Internet Exploder 10 or 11. Create a forum with grade type set to point with a value of 100. From the forum view, you'll see a 'grade users' button. Click it to view the new grading interface. Just make sure you are able to load the view, grade a student, etc.
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull Master Branch:
      MDL-67137-master

      Description

      So it turns out that babel-polyfill (and core-js/stable which replace it) do not include polyfills for DOM things.

      Some DOM things, like `Element.closest` do not work in IE and so we need to add our own polyfill.
      Yay.

      MDN provide polyfills for us, though they don't give any indiciation as to the license.

        Attachments

          Activity

            People

            • Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Carlos Escobedo
              Integrator:
              Jake Dallimore
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 57 minutes
                1h 57m