[MDL-67148] Undefined auth_name in tool_mobile external test - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.6.6, 3.7.2, 3.8, 3.9
Fix Version/s: 3.7.4, 3.8.1
Component/s: Authentication, Unit tests
Labels:
- ci
- triaged

Affected Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE
Pull from Repository:
git://github.com/junpataleta/moodle.git
Pull Master Branch:
~~MDL-67148~~-master
Pull Master Diff URL:
https://github.com/junpataleta/moodle/compare/01aa126848...MDL-67148-master
Workaround:

Hide

Add set_config('auth_name', 'CAS', 'auth_cas'); to line 125 of the admin/tool/mobile/tests/externallib_test.php file

Show
Add set_config('auth_name', 'CAS', 'auth_cas'); to line 125 of the admin/tool/mobile/tests/externallib_test.php file
Testing Instructions:
Hide

Run tool_mobile tests.

mdk phpunit -r -s tool_mobile

Confirm that everything passes.
Show
Run tool_mobile tests. mdk phpunit -r -s tool_mobile Confirm that everything passes.

Description

When the PHP LDAP module is not installed, the tool_mobile PHPUnit external test throws an error:

vendor/bin/phpunit "tool_mobile_external_testcase" admin/tool/mobile/tests/externallib_test.php

(1) tool_mobile_external_testcase::test_get_public_config
Undefined property: stdClass::$auth_name
auth/cas/auth.php:386
lib/authlib.php:731
admin/tool/mobile/classes/api.php:205
admin/tool/mobile/classes/external.php:125
admin/tool/mobile/tests/externallib_test.php:147
lib/phpunit/classes/advanced_testcase.php:80

The auth_name configuration setting of auth_cas is not set when the PHP LDAP module is absent.

Attachments

Issue Links

is a regression caused by

MDL-66582 "auth_logo" in auth_cas and auth_shibboleth throw an invalidresponse exception when calling "tool_mobile_get_public_config"

Closed

Activity

People

Assignee:: Jun Pataleta

Reporter:: Renaat Debleu

Peer reviewer:: Carlos Escobedo

Integrator:: Eloy Lafuente (stronk7)

Tester:: Eloy Lafuente (stronk7)

Participants:: Carlos Escobedo, CiBoT, Eloy Lafuente (stronk7), Jun Pataleta, Renaat Debleu, Sara Arjona (@sarjona)

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 06/Nov/19 10:36 PM

Updated:: 26/May/20 5:44 AM

Resolved:: 22/Nov/19 7:39 AM

Fix Release Date:: 13/Jan/20

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1h 20m