Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67166

Some H5P content types are not rendered properly using classic theme

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.8
    • Fix Version/s: 3.8
    • Component/s: H5P, Themes
    • Labels:
    • Testing Instructions:
      Hide

      IMPORTANT: Test using both themes, BOOST and CLASSIC.

      1. Login as Admin
      2. Create a new course "C1"
      3. In the new course, create a label resource
      4. Click the H5P button in the Atto editor
      5. Upload the "course-presentation.h5p" file
      6. Save changes
      7. Verify the H5P activity is rendered well, the height and with of the H5P content should fit the label resource container
      8. Create a Page resource "Page 1"
      9. In the "Page content" section of "Page 1", click the H5P button in the Atto editor
      10. Upload the "arithmetic-quiz.h5p" file
      11. Add a text below the H5P content (for instance: "Second H5P content")
      12. Click again the H5P button
      13. Upload the "guess-the-answer.h5p" file
      14. Save changes
      15. Verify the H5P activities are rendered well, the height and with of the H5P content should fit the Page resource container 

       

      Show
      IMPORTANT : Test using both themes, BOOST and CLASSIC. Login as Admin Create a new course "C1" In the new course, create a label resource Click the H5P button in the Atto editor Upload the "course-presentation.h5p" file Save changes Verify the H5P activity is rendered well, the height and with of the H5P content should fit the label resource container Create a Page resource "Page 1" In the "Page content" section of "Page 1", click the H5P button in the Atto editor Upload the "arithmetic-quiz.h5p" file Add a text below the H5P content (for instance: "Second H5P content") Click again the H5P button Upload the "guess-the-answer.h5p" file Save changes Verify the H5P activities are rendered well, the height and with of the H5P content should fit the Page resource container   
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-67166-master
    • Sprint:
      H5P Sprint Relase 3.8

      Description

      Some H5P content-types are not resized properly using 'classic theme.

      There are problems at least with 

      Arithmetic quiz

      Course presentation

      Guess the answer

      Attached some H5P content to testing.

      To reproduce: 

      • Go to Site administration > Appearance > Themes > Theme selector. Change default theme to Classic.
      • Go to Site administration > Plugins > Filters > Manage filters
      • Check Display H5P filter is enabled and in a higher position than 'Convert URLs into links and images' filter 
      • Create a Page resource into a course
      • Using H5P atto button add attached H5P contents to Page Description
      • Save and Display

        Attachments

        1. arithmetic-quiz.h5p
          731 kB
        2. boost.png
          boost.png
          739 kB
        3. classic.png
          classic.png
          826 kB
        4. course-presentation.h5p
          4.14 MB
        5. guess-the-answer.h5p
          861 kB

          Issue Links

            Activity

              People

              Assignee:
              basbrands Bas Brands
              Reporter:
              amaia Amaia Anabitarte
              Peer reviewer:
              Amaia Anabitarte
              Integrator:
              Sara Arjona (@sarjona)
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 25 minutes
                  2h 25m