-
Sub-task
-
Resolution: Fixed
-
Minor
-
3.6.6, 3.7.2, 3.8, 3.9
-
MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
-
MOODLE_37_STABLE, MOODLE_38_STABLE
-
MDL-67168-master -
This was detected while progressing with MDL-67114, so I'm creating it as subtask there because it's leading to php74 failures (not happening in older php versions).
In any case, the code looks just "wrong", or I've not been able to find an explanation to it, so it requires review and, if possible, amendment.
Code: https://github.com/moodle/moodle/blob/master/mod/forum/classes/task/send_user_digests.php#L202-L204
Apparently we are replacing the whole array by the (boolean) result of a capability check. So any future use of the original array becomes borked.
For your consideration, ciao