XMLWordPrintable

Details

    • Sub-task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.6.6, 3.7.2, 3.8, 3.9
    • 3.7.4, 3.8.1
    • Forum

    Description

      This was detected while progressing with MDL-67114, so I'm creating it as subtask there because it's leading to php74 failures (not happening in older php versions).

      In any case, the code looks just "wrong", or I've not been able to find an explanation to it, so it requires review and, if possible, amendment.

      Code: https://github.com/moodle/moodle/blob/master/mod/forum/classes/task/send_user_digests.php#L202-L204

      Apparently we are replacing the whole array by the (boolean) result of a capability check. So any future use of the original array becomes borked.

      For your consideration, ciao

      Attachments

        Activity

          People

            dobedobedoh Andrew Lyons
            stronk7 Eloy Lafuente (stronk7)
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            CiBoT CiBoT
            Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              13/Jan/20

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours
                3h