Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67173

core_h5p_get_trusted_h5p_file returns a code error if URL is not local

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.8
    • Fix Version/s: 3.8
    • Component/s: H5P, Web Services
    • Labels:
    • Sprint:
      H5P Sprint Relase 3.8

      Description

      If you set a URL that isn't local to the H5P player, in web you see this error: "Invalid H5P content URL.".

      However, the WebService returns a coding error in this case: "Coding error detected, it must be fixed by a programmer: out_al_local_url called on a non-local URL"

      The WebService should treat this case and return the same error as the web player instead of a coding error.

      To reproduce it, just call the WebService with a URL that doesn't belong to the site, it doesn't matter if it's not a valid URL.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              cescobedo Carlos Escobedo
              Reporter:
              dpalou Dani Palou
              Peer reviewer:
              Juan Leyva
              Integrator:
              Sara Arjona (@sarjona)
              Tester:
              CiBoT
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 55 minutes
                  1h 55m