Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67184

Order of filters impacts H5P filter

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.8
    • Fix Version/s: 3.8
    • Component/s: H5P
    • Labels:
    • Testing Instructions:
      Hide

      Testing scenario 1: New clean install site.

      1. Login as admin
      2. Go to Site administration > Plugins > Filters > Manage filters
      3. Check the 'Display H5P' filter is enabled and appears above the "Convert URLs into links and images" and "Activity names auto-linking" filters.

      Testing scenario 2: Upgrade the filter.

      1. Go to Site administration > Plugins > Filters > Manage filters
      2. Move the Display H5P filter to the bottom of the list of filters enabled.
      3. Edit the filter/displayh5p/version.php file and set $plugin->version = 2019110700;
      4. In a console, execute the following command (to reset the filter_displayh5p version): mdk run version.php
      5. Go to  Site administration > Notifications
      6. Upgrade the plugin.
      7. Edit the filter/displayh5p/version.php file and set $plugin->version = 2019110800;
      8. Go to  Site administration > Notifications
      9. Upgrade the plugin.
      10. Go to Site administration > Plugins > Filters > Manage filters
      11. Check the 'Display H5P' filter is enabled and appears above the "Convert URLs into links and images" and "Activity names auto-linking" filters.

      Testing scenario 3: Upgrade the filter when is disabled.

      1. Go to Site administration > Plugins > Filters > Manage filters
      2. Disable the Display H5P filter.
      3. Edit the filter/displayh5p/version.php file and set $plugin->version = 2019110700;
      4. In a console, execute the following command (to reset the filter_displayh5p version): mdk run version.php
      5. Go to  Site administration > Notifications
      6. Upgrade the plugin.
      7. Edit the filter/displayh5p/version.php file and set $plugin->version = 2019110800;
      8. Go to  Site administration > Notifications
      9. Upgrade the plugin.
      10. Go to Site administration > Plugins > Filters > Manage filters
      11. Check the 'Display H5P' filter is enabled and appears above the "Convert URLs into links and images" and "Activity names auto-linking" filters.

      Testing scenario 4: Upgrade the filter when is Off, but available.

      1. Go to Site administration > Plugins > Filters > Manage filters
      2. Set Off, but available the Display H5P filter.
      3. Edit the filter/displayh5p/version.php file and set $plugin->version = 2019110700;
      4. In a console, execute the following command (to reset the filter_displayh5p version): mdk run version.php
      5. Go to  Site administration > Notifications
      6. Upgrade the plugin.
      7. Edit the filter/displayh5p/version.php file and set $plugin->version = 2019110800;
      8. Go to  Site administration > Notifications
      9. Upgrade the plugin.
      10. Go to Site administration > Plugins > Filters > Manage filters
      11. Check the 'Display H5P' filter is enabled and appears above the "Convert URLs into links and images" and "Activity names auto-linking" filters.

       

      Show
      Testing scenario 1: New clean install site. Login as admin Go to Site administration > Plugins > Filters > Manage filters Check  the 'Display H5P' filter is enabled and appears above the "Convert URLs into links and images" and "Activity names auto-linking" filters. Testing scenario 2: Upgrade the filter. Go to Site administration > Plugins > Filters > Manage filters Move the Display H5P filter to the bottom of the list of filters enabled. Edit the filter/displayh5p/version.php file and set $plugin->version = 2019110700; In a console, execute the following command (to reset the filter_displayh5p version):  mdk run version.php Go to  Site administration > Notifications Upgrade the plugin. Edit the filter/displayh5p/version.php file and set $plugin->version = 2019110800; Go to  Site administration > Notifications Upgrade the plugin. Go to Site administration > Plugins > Filters > Manage filters Check  the 'Display H5P' filter is enabled and appears above the "Convert URLs into links and images" and "Activity names auto-linking" filters. Testing scenario 3: Upgrade the filter when is disabled. Go to Site administration > Plugins > Filters > Manage filters Disable  the Display H5P filter. Edit the filter/displayh5p/version.php file and set $plugin->version = 2019110700; In a console, execute the following command (to reset the filter_displayh5p version):  mdk run version.php Go to  Site administration > Notifications Upgrade the plugin. Edit the filter/displayh5p/version.php file and set $plugin->version = 2019110800; Go to  Site administration > Notifications Upgrade the plugin. Go to Site administration > Plugins > Filters > Manage filters Check  the 'Display H5P' filter is enabled and appears above the "Convert URLs into links and images" and "Activity names auto-linking" filters. Testing scenario 4: Upgrade the filter when is Off, but available. Go to Site administration > Plugins > Filters > Manage filters Set Off, but available  the Display H5P filter. Edit the filter/displayh5p/version.php file and set $plugin->version = 2019110700; In a console, execute the following command (to reset the filter_displayh5p version):  mdk run version.php Go to  Site administration > Notifications Upgrade the plugin. Edit the filter/displayh5p/version.php file and set $plugin->version = 2019110800; Go to  Site administration > Notifications Upgrade the plugin. Go to Site administration > Plugins > Filters > Manage filters Check  the 'Display H5P' filter is enabled and appears above the "Convert URLs into links and images" and "Activity names auto-linking" filters.  
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull Master Branch:
      MDL-67184-master
    • Sprint:
      H5P Sprint Relase 3.8

      Description

      For the H5P filter to work the "Display H5P" filter should be placed before the "Convert URLs into links and images" and "Activity names auto-linking" filters.

      By default it appears after.

      We need to change the default order or automatically re-arrange.

       

        Attachments

          Activity

            People

            Assignee:
            cescobedo Carlos Escobedo
            Reporter:
            sanderbangma Sander Bangma
            Peer reviewer:
            Amaia Anabitarte
            Integrator:
            Sara Arjona (@sarjona)
            Tester:
            Gladys Basiana
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              18/Nov/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 6 hours, 30 minutes
                6h 30m