Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67196

Privacy data export request download size phpunit error

    XMLWordPrintable

Details

    Description

      We have started to get, once again, failures related to the max size of privacy data exports.

      Link: https://ci.moodle.org/job/W37.03.03%20-%20Behat%20-%20Chrome%20+%20MariaDB%20(lowest)/lastFailedBuild/

      001 Scenario: As a student, request data export and then download it when approved, unless it has expired # /Users/stronk7/git_moodle/moodle/admin/tool/dataprivacy/tests/behat/dataexport.feature:67
            And following "Download" should download between "1" and "142000" bytes                             # /Users/stronk7/git_moodle/moodle/admin/tool/dataprivacy/tests/behat/dataexport.feature:92
              Downloaded data was 142801 bytes, expecting between 1 and 142000 (Behat\Mink\Exception\ExpectationException)
      

      1. Current max size (failing) is 142000
      2. We have got reports with 142632, 142738, 142789, 142834 sizes
      3. Curiously it doesn't fail with all databases. PostreSQL leads to files below 1), but MariaDB, SQL*Server... fail. I'd expect all databases to be leading to the same content.
      4. The issue leading to the increment in sizes is MDL-66893 where a lot of new CSS was added.
      5. We are going to raise the max size to 144000
      6. This test is "silly". We should try to switch to some other assertions looking for content instead of size.

      Working in a fix...

      Attachments

        Issue Links

          Activity

            People

              stronk7 Eloy Lafuente (stronk7)
              stronk7 Eloy Lafuente (stronk7)
              Tim Hunt Tim Hunt
              Sara Arjona (@sarjona) Sara Arjona (@sarjona)
              CiBoT CiBoT
              Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                18/Nov/19

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour
                  1h