Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67215

generalexceptionmessage when attempting to save an annotated PDF assignment submission

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.8
    • Fix Version/s: 3.8
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide

      Requirements:

      1. A course with a teacher and student enrolled.
      2. An assignment with PDF annotation enabled
      3. A submission made by student

      Testing:

      1. Log in as the teacher
      2. Go to the assignment and view all submissions
      3. Grade the student's submission.
      4. When in the grading interface, rotate the document and add an annotation
      5. Save the changes
      6. Confirm no error comes up.
      Show
      Requirements: A course with a teacher and student enrolled. An assignment with PDF annotation enabled A submission made by student Testing: Log in as the teacher Go to the assignment and view all submissions Grade the student's submission. When in the grading interface, rotate the document and add an annotation Save the changes Confirm no error comes up.
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-67215-master

      Description

      As reported by Moien Abadi in MDLQA-13869, when a teacher attempts to save a rotated annotated PDF assignment submission the following error is displayed:

      generalexceptionmessage

      Exception - Width or height parameter needs to be larger than zero.
      File: .../editpdf/fpdi/FpdiTrait.php
      Line: 468
      Stack trace:
      Error code: generalexceptionmessage

      • line 468 of /mod/assign/feedback/editpdf/fpdi/FpdiTrait.php: InvalidArgumentException thrown
      • line 130 of /mod/assign/feedback/editpdf/fpdi/Tcpdf/Fpdi.php: call to setasign\Fpdi\Tcpdf\Fpdi->getImportedPageSize()
      • line 782 of /mod/assign/feedback/editpdf/classes/pdf.php: call to setasign\Fpdi\Tcpdf\Fpdi->getTemplateSize()
      • line 704 of /mod/assign/feedback/editpdf/classes/document_services.php: call to assignfeedback_editpdf\pdf->add_image_page()
      • line 271 of /mod/assign/feedback/editpdf/locallib.php: call to assignfeedback_editpdf\document_services::generate_feedback_document()
      • line 8315 of /mod/assign/locallib.php: call to assign_feedback_editpdf->save()
      • line 8482 of /mod/assign/locallib.php: call to assign->apply_grade_to_user()
      • line 1584 of /mod/assign/externallib.php: call to assign->save_grade()
      • line ? of unknownfile: call to mod_assign_external::submit_grading_form()
      • line 244 of /lib/externallib.php: call to call_user_func_array()
      • line 79 of /lib/ajax/service.php: call to external_api::call_external_function()

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              peterdias Peter Dias
              Reporter:
              tsala Helen Foster
              Peer reviewer:
              Jake Dallimore Jake Dallimore
              Integrator:
              Adrian Greeve Adrian Greeve
              Tester:
              Gladys Basiana Gladys Basiana
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 11 minutes
                  1h 11m