Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67218

Saving the forum settings form when the activity has grades disables grading

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.7.3, 3.8
    • Fix Version/s: 3.7.4
    • Component/s: Forms Library, Forum
    • Labels:
    • Testing Instructions:
      Hide

      Master:

      1. Login as teacher
      2. Create a forum:
        1. Set Whole forum grading to Point-based
        2. Set up some form of ratings (anything will do)
        3. Save
      3. Edit the forum settings
      4. Expand the "Grade" section
        1. Confirm that the "Rating" settings are visible and not disabled
        2. Confirm that the "Whole forum grading" settings are visible and not disabled
      5. Login in a second browser as a student
      6. Create a discussion in the forum
      7. Close the student window and go back to being a teacher again
      8. View the discussion and give a Rating for the post
      9. View the list of discussions
      10. Click on the "Grade users" button
      11. Give the user a grade
      12. Edit the forum settings
      13. Expand the "Grade" section
        1. Confirm that the "Rating" settings are visible but disabled
        2. Confirm that the "Whole forum grading" settings are visible but disabled
      14. Save changes on the page
      15. Edit the forum settings again
      16. Expand the "Grade" section
        1. Confirm that the "Rating" settings are visible but disabled
        2. Confirm that the "Whole forum grading" settings are visible but disabled

      All branches (including master):

      1. Create an assignment
      2. Edit settings for the assignment
      3. Expand the "Grade" section
        1. Confirm that the grade settings are visible and not disabled
      4. As a teacher grade any student (you don't need to upload content for that student)
      5. Edit settings for the assignment
      6. Expand the "Grade" section
        1. Confirm that the grade settings are visible but disabled
      7. Save changes
      8. Edit settings for the assignment again
      9. Expand the "Grade" section
        1. Confirm that the grade settings are visible but disabled
      Show
      Master: Login as teacher Create a forum: Set Whole forum grading to Point-based Set up some form of ratings (anything will do) Save Edit the forum settings Expand the "Grade" section Confirm that the "Rating" settings are visible and not disabled Confirm that the "Whole forum grading" settings are visible and not disabled Login in a second browser as a student Create a discussion in the forum Close the student window and go back to being a teacher again View the discussion and give a Rating for the post View the list of discussions Click on the "Grade users" button Give the user a grade Edit the forum settings Expand the "Grade" section Confirm that the "Rating" settings are visible but disabled Confirm that the "Whole forum grading" settings are visible but disabled Save changes on the page Edit the forum settings again Expand the "Grade" section Confirm that the "Rating" settings are visible but disabled Confirm that the "Whole forum grading" settings are visible but disabled All branches (including master): Create an assignment Edit settings for the assignment Expand the "Grade" section Confirm that the grade settings are visible and not disabled As a teacher grade any student (you don't need to upload content for that student) Edit settings for the assignment Expand the "Grade" section Confirm that the grade settings are visible but disabled Save changes Edit settings for the assignment again Expand the "Grade" section Confirm that the grade settings are visible but disabled
    • Affected Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull 3.7 Branch:
    • Pull Master Branch:
      MDL-67218-master

      Description

      Given I have a forum with grading enabled
      And I have grades saved for students in that forum
      When I edit the settings of the forum
      And I do not make any changes
      When I press "Save and display"
      Then grading should still be enabled

      Right now it is not.
      This is because of a pre-existing bug in the the modgrade form type which discards the grade setting if the activity cannot be rescaled.

        Attachments

          Activity

            People

            Assignee:
            dobedobedoh Andrew Nicols
            Reporter:
            dobedobedoh Andrew Nicols
            Peer reviewer:
            Simey Lameze
            Integrator:
            Jun Pataleta
            Tester:
            Gladys Basiana
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/Jan/20

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours, 48 minutes
                4h 48m