Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67233

Choices with only open dates in the future do not appear on timeline

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Testing MDL-65310

      1. Create a course with activity (e.g Quiz, Lesson, Workshop)
      2. Enable 'available from date' using a date from the past (e.g 1 hour ago, 1 day ago, 1 week ago) 
      3. Make sure due date is not enabled
      4. Enrol a test student
      5. Login as the test student
      6. The activity will not show as overdue on the timeline block

      MDLQA-14031
      This test requires a course with a teacher and student enrolled.

      1. Log in as a teacher and create five choice activities as follows:
        • Choice A (in the past) - enable 'Allow responses until' and set it to a date in the past (and optionally set 'Allow responses from' to a date in the past)
        • Choice B (in progress) - set 'Allow responses until' to a date in the future (and optionally set 'Allow responses from' to a date in the past)
        • Choice C (in progress) - set as for Choice B and also set 'Allow choice to be updated' to Yes
        • Choice D (in the future) - set 'Allow responses from' to a date in the future
        • Choice E (in the future) - set 'Allow responses from' to a date in the future and set 'Allow responses until' to a date further in the future
      2. Log in as a student and go to the Timeline block on the dashboard.
      3. Check that Choice A is not shown.
      4. Check that 'Choice B closes' and 'Choice C closes' are shown with dates and times as set for 'Allow responses until' and with links to the choice activities.
      5. Check that 'Choice D opens' is shown with the date and time as set for 'Allow responses from'.
      6. Check that 'Choice E closes' is shown with the date and time as set for 'Allow responses until'.
      7. Go to Choice B and submit a response.
      8. Check that Choice B is no longer shown in the Timeline block.
      9. Go to Choice C and submit a response.
      10. Check that Choice C is no longer shown in the Timeline block.

      Test 3:(contd from previous setup)

      1. Create an assignment with a due date in the past(not <2weeks)
      2. Log in as a student and confirm you see the assignment in the timeline under overdue
      Show
      Testing MDL-65310 Create a course with activity (e.g Quiz, Lesson, Workshop) Enable 'available from date' using a date from the past (e.g 1 hour ago, 1 day ago, 1 week ago)  Make sure due date is not enabled Enrol a test student Login as the test student The activity will not show as overdue on the timeline block MDLQA-14031 This test requires a course with a teacher and student enrolled. Log in as a teacher and create five choice activities as follows: Choice A (in the past) - enable 'Allow responses until' and set it to a date in the past (and optionally set 'Allow responses from' to a date in the past) Choice B (in progress) - set 'Allow responses until' to a date in the future (and optionally set 'Allow responses from' to a date in the past) Choice C (in progress) - set as for Choice B and also set 'Allow choice to be updated' to Yes Choice D (in the future) - set 'Allow responses from' to a date in the future Choice E (in the future) - set 'Allow responses from' to a date in the future and set 'Allow responses until' to a date further in the future Log in as a student and go to the Timeline block on the dashboard. Check that Choice A is not shown. Check that 'Choice B closes' and 'Choice C closes' are shown with dates and times as set for 'Allow responses until' and with links to the choice activities. Check that 'Choice D opens' is shown with the date and time as set for 'Allow responses from'. Check that 'Choice E closes' is shown with the date and time as set for 'Allow responses until'. Go to Choice B and submit a response. Check that Choice B is no longer shown in the Timeline block. Go to Choice C and submit a response. Check that Choice C is no longer shown in the Timeline block. Test 3:(contd from previous setup) Create an assignment with a due date in the past(not <2weeks) Log in as a student and confirm you see the assignment in the timeline under overdue
    • Affected Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Pull from Repository:
    • Pull 3.8 Branch:
    • Pull Master Branch:
      MDL-67233-master
    • Story Points:
      1
    • Sprint:
      Activity Sprint 1, Activity Sprint 2, Activity Sprint 3

      Description

      If you have a choice with only an open date in the future, this does not then appear in the timeline block

      The issue is with the event_list.js:270 which filters out the 'Choice open' event being sent down regardless of whether it's in the future or not

        Attachments

        1. T1S6.png
          T1S6.png
          28 kB
        2. T1S6-quiz opened.png
          T1S6-quiz opened.png
          39 kB
        3. T2S10.png
          T2S10.png
          63 kB
        4. T2S3-6.png
          T2S3-6.png
          100 kB
        5. T2S8.png
          T2S8.png
          82 kB
        6. T3S2.png
          T3S2.png
          97 kB

          Issue Links

            Activity

              People

              Assignee:
              peterdias Peter Dias
              Reporter:
              peterdias Peter Dias
              Peer reviewer:
              Simey Lameze
              Integrator:
              Adrian Greeve
              Tester:
              Mathew May
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Jan/20

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 13 minutes
                  1d 13m