Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67250

Removal of httpswwwroot would break a lot of plugins and is not really needed

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.8
    • Fix Version/s: 3.8
    • Component/s: Other
    • Labels:

      Description

      The issue MDL-46267 introduces a final deprecation step for the httpswwwroot and removes it from the core.

      However, the setting is still used in many plugins - 201 in the plugins directory. These all will suddenly stop working in 3.8.

      We did not have a way to raise a proper deprecation debugging warning when the httpswwwroot is still used. So no-one is really aware about this problem and prepared for it.

      I believe we must:

      1. re-introduce the httpswwwroot and keep it forever as an alias for the wwwroot.
      2. improve the CI tools in the plugins directory and in travis (moodle-plugin-ci) to raise a warning/error when httpswwwroot is found in the plugin's code.

        Attachments

        1. httpswwwroot-in-plugins.txt
          104 kB
          David Mudrák (@mudrd8mz)

          Issue Links

            Activity

              People

              Assignee:
              mudrd8mz David Mudrák (@mudrd8mz)
              Reporter:
              mudrd8mz David Mudrák (@mudrd8mz)
              Peer reviewer:
              Eloy Lafuente (stronk7)
              Integrator:
              Andrew Nicols
              Tester:
              CiBoT
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour
                  1h