Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67264

Rework/Redesign the activity chooser

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Covered by Behat & PHPunit.

      Manual testing instructions:

      Setup

      1.  Login as Admin
      2. Create a Course

      Test 1 (activity chooser layout)

      1. Go to the Course.
      2. Turn editing on.
      3. Click on any 'Add activity or resource' link
        1. make sure the activity chooser popup opens.
        2. make sure the available activities are presented in a grid layout.
        3. make sure each activity item has:
          1. activity icon (link)
          2. name of the activity
          3. info icon (link)

      Test 2 (choose to add activity through the activity chooser)

      1. Go to the Course
      2. Turn editing on.
      3. Click on any 'Add activity or resource' link
      4. In the activity chooser popup click on the activity icon (link) of any activity item (ex. Assignment)
        1. make sure you are forwarded to the "Adding a new Assignment" page
      5. Fill out the form and press "Save and return to course"
        1. make sure the Assignment was successfully added to the course.

      Test 3 (disabled activities are not shown in the activity chooser)

      1. Go to the Course
      2. Turn editing on.
      3. Click on any 'Add activity or resource' link
        1. make sure an "Assignment" activity item exist in the activity chooser popup
      4. Go to Site administration > Plugins > Activity modules > Manage activities
      5. Hide (disable) the "Assignment" activity
      6. Go back to the course 
      7. Turn editing on.
      8. Click on any 'Add activity or resource' link
        1. make sure an "Assignment" activity item does NOT exist in the activity chooser popup

      Test 4 (configured external tools are shown in the activity chooser)

      1. Go to Site administration > Plugins > Activity modules > External tool > Manage tools
      2. Add a new tool
        1. Tool name = Example
        2. Tool URL = www.example.com
        3. Tool configuration usage = Show in activity chooser as a preconfigured tool
      3. Go back to the course
      4. Turn editing on.
      5. Click on any 'Add activity or resource' link
        1. make sure an "Example" activity item does exist in the activity chooser popup

      Test 5 (Display the summary of an activity)

      1. Go to the Course
      2. Turn editing on.
      3. Click on any 'Add activity or resource' link.
      4. In the activity chooser popup click on the info icon (link) of any activity item (ex. Assignment)
        1. make sure a new panel is being opened in a sliding motion
        2. make sure the summary panel contains
          1. full summary of the activity
          2. "Back" button
          3. "Add" button
        3. make sure you cannot see the activity chooser items (grid layout) anymore

      Test 6 (add activity through the activity's summary panel)

      1. Go to the Course
      2. Turn editing on.
      3. Click on any 'Add activity or resource' link.
      4. In the activity chooser popup click on the info icon (link) of any activity item (ex. Assignment)
      5. In the activity's summary panel click on the "Add" button
        1. make sure you are forwarded to the "Adding a new Assignment" page
      6. Fill out the form and press "Save and return to course"
        1. make sure the Assignment was successfully added to the course.

      Test 7 (Hide the summary of an activity)

      1. Go to the Course
      2. Turn editing on.
      3. Click on any 'Add activity or resource' link.
      4. In the activity chooser popup click on the info icon (link) of any activity item (ex. Assignment)
      5. In the activity's summary panel click on the "Back" button
        1. make sure the summary panel is being closed in a sliding motion
        2. make sure you can see the activity chooser items (grid layout) once again.
      Show
      Covered by Behat & PHPunit. Manual testing instructions: Setup  Login as Admin Create a Course Test 1 (activity chooser layout) Go to the Course. Turn editing on. Click on any 'Add activity or resource' link make sure the activity chooser popup opens. make sure the available activities are presented in a grid layout. make sure each activity item has: activity icon (link) name of the activity info icon (link) Test 2 (choose to add activity through the activity chooser) Go to the Course Turn editing on. Click on any 'Add activity or resource' link In the activity chooser popup click on the activity icon (link) of any activity item (ex. Assignment) make sure you are forwarded to the "Adding a new Assignment" page Fill out the form and press "Save and return to course" make sure the Assignment was successfully added to the course. Test 3 (disabled activities are not shown in the activity chooser) Go to the Course Turn editing on. Click on any 'Add activity or resource' link make sure an "Assignment" activity item exist in the activity chooser popup Go to Site administration > Plugins > Activity modules > Manage activities Hide (disable) the "Assignment" activity Go back to the course  Turn editing on. Click on any 'Add activity or resource' link make sure an "Assignment" activity item does NOT exist in the activity chooser popup Test 4 (configured external tools are shown in the activity chooser) Go to Site administration > Plugins > Activity modules > External tool > Manage tools Add a new tool Tool name = Example Tool URL = www.example.com Tool configuration usage = Show in activity chooser as a preconfigured tool Go back to the course Turn editing on. Click on any 'Add activity or resource' link make sure an "Example" activity item does exist in the activity chooser popup Test 5 (Display the summary of an activity) Go to the Course Turn editing on. Click on any 'Add activity or resource' link. In the activity chooser popup click on the info icon (link) of any activity item (ex. Assignment) make sure a new panel is being opened in a sliding motion make sure the summary panel contains full summary of the activity "Back" button "Add" button make sure you cannot see the activity chooser items (grid layout) anymore Test 6 (add activity through the activity's summary panel) Go to the Course Turn editing on. Click on any 'Add activity or resource' link. In the activity chooser popup click on the info icon (link) of any activity item (ex. Assignment) In the activity's summary panel click on the "Add" button make sure you are forwarded to the "Adding a new Assignment" page Fill out the form and press "Save and return to course" make sure the Assignment was successfully added to the course. Test 7 (Hide the summary of an activity) Go to the Course Turn editing on. Click on any 'Add activity or resource' link. In the activity chooser popup click on the info icon (link) of any activity item (ex. Assignment) In the activity's summary panel click on the "Back" button make sure the summary panel is being closed in a sliding motion make sure you can see the activity chooser items (grid layout) once again.
    • Affected Branches:
      MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull Master Branch:
      MDL-67264-review-squashed
    • Story Points:
      3
    • Sprint:
      Activity Sprint 6

      Description

      Redesign/restructure the activity chooser to fit the current design mock-ups

      User stories

      Story Approach
      As a teacher, when I click on the activity choose link(the link), I then see the activity picker(the modal), I can then see the activities/resources(the elements) in a grid format and I should not see any tabs(the tabs) in the modal.  
      As a teacher when there are lots of elements in the modal, I can scroll down in the modal to view them. Allow scrolling
      As a teacher I can find out more information about the elements in the modal. Click the 'i' icon and be taken to another page with more information.
      As a teacher I should be able to add an element once I have read the detailed information. A button to add the activity should be present on this page.
      As a teacher I can select and configure an activity. Click the activity icon and jumps immediately to the activity settings page

      Acceptance criteria

      • All visible activities are listed in the modal.
      • Activities are to be displayed in a grid as per the prototype.
      • Third party activities are listed in the modal when installed (and visible).
      • When there are more activities than will fit in the modal, scrolling down will display them.
      • Clicking on the 'i' (information) icon shows the information about the module.
        • Clicking the i results in a page sliding in from the right to show the information (The same as the activity chooser in H5P).
        • A button to add the activity should be available from the information page.
      • A single click of an activity icon will redirect to the mod_edit page for configuration.
      • Activities can show additional items in the activity chooser.
      • Adding activities works using Jaws and NVDA.
        • Keyboard navigation is possible.
      • Current behat tests should still work.
      • Behat tests are created to cover new functionality (showing information, adding activities from the information page)
      • If new methods / functions are added they are covered by unit tests.

       

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              mathewmay Mathew May
              Reporter:
              peterdias Peter Dias
              Integrator:
              Andrew Nicols
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              1 Vote for this issue
              Watchers:
              16 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jun/20

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 days, 18 minutes
                  4d 18m