Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67285

Filepicker does not work in the modal forms - unable to click on input texts

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Reported issue fix

      1. Open Calendar
      2. click "New event"
      3. click "Show more..."
      4. In the description click on the "Image" button
      5. try to put anything in the text input fields in the "chose image" popup
        1. Confirm that you are able to do so

      Regression testing

      1. Create a forum
        1. Enable "Whole forum grading"
      2. Post some content as a user enrolled in the course
      3. Grade that forum
      4. Find the user who you posted as
      5. Click the "View full discussion" link
        1. Confirm that you can interact with the new dialogue
      6. Close the new dialogue
      7. RE-open it
        1. Confirm that you can interact with the new dialogue

      Smoke testing

      1. Find as many modal dialogues as you can and test them
      2. Especially look at modals which open other modals
      Show
      Reported issue fix Open Calendar click "New event" click "Show more..." In the description click on the "Image" button try to put anything in the text input fields in the "chose image" popup Confirm that you are able to do so Regression testing Create a forum Enable "Whole forum grading" Post some content as a user enrolled in the course Grade that forum Find the user who you posted as Click the "View full discussion" link Confirm that you can interact with the new dialogue Close the new dialogue RE-open it Confirm that you can interact with the new dialogue Smoke testing Find as many modal dialogues as you can and test them Especially look at modals which open other modals
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull Master Branch:
      MDL-67285-master

      Description

      This breaks a lot in Moodle Workplace (because we use modal forms everywhere) but can be easily reproduced on https://qa.moodledemo.net/ too:

      • Open Calendar
      • click "New event"
      • click "Show more..."
      • In the description click on the "Image" button
      • try to put anything in the text input fields in the "chose image" popup - instead the fields in the modal form will be selected

      I traced it down to the MDL-67207 , particularly commit
      https://github.com/moodle/moodle/commit/c50bc1bf7c5985b47903840d27e783db1f35f403

      If this commit is reverted everything works

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              marina Marina Glancy
              Peer reviewer:
              Mathew May
              Integrator:
              Adrian Greeve
              Tester:
              Gladys Basiana
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              2 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Jan/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 25 minutes
                  5h 25m