Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67296

Consider moving h5p tests accessing h5p.org to exttests

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.8, 3.9
    • 3.8.2
    • H5P, Unit tests
    • MOODLE_38_STABLE, MOODLE_39_STABLE
    • MOODLE_38_STABLE
    • MDL-67296-master
    • Hide

      Set up the environment

      1. Download the attached files to your local web server.
      2. Update your config.php to point the tests to wherever you've hosted the attached files, for example: 
        define('TEST_EXTERNAL_FILES_HTTP_URL', 'http://exttests');

      Run unit tests

      1. Run H5P tests:
        • \h5p_get_content_types_task_test (lib/tests/h5p_get_content_types_task_test.php)
        • \core_h5p\h5p_core_test (h5p/tests/h5p_core_test.php)
      2. Confirm lack of failure
      Show
      Set up the environment Download the attached files to your local web server. If they have been added to https://github.com/moodlehq/moodle-exttests , you can clone the repo to your local web server or run it as a Docker image. Update your config.php to point the tests to wherever you've hosted the attached files, for example:  define('TEST_EXTERNAL_FILES_HTTP_URL', 'http://exttests'); Run unit tests Run H5P tests: \h5p_get_content_types_task_test (lib/tests/h5p_get_content_types_task_test.php) \core_h5p\h5p_core_test (h5p/tests/h5p_core_test.php) Confirm  lack of failure

    Description

      It seems that a number (undetermined at the time of write this) of unit-tests (maybe also behat tests) are accessing to external systems, like h5p.org to fetch various information.

      That may cause (uncontrolled by us) problems when the external systems are unreachable, slow... so, instead we should consider performing all those tests against our https://github.com/moodlehq/moodle-exttests exttests repository, that can be installed locally, and provides constant/fixed content.

      So this issue is about to detect were in h5p we are using external (3rd part) systems and add standard support to exttests (see TEST_EXTERNAL_FILES_HTTPS_URL...) for them.

      Ciao

      Attachments

        Issue Links

          blocks

          Improvement - An enhancement to an existing Moodle feature. MDL-67192 H5P: get site UUID using H5P API

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will be (partly) resolved by

          Improvement - An enhancement to an existing Moodle feature. MDL-67464 Move behat tests accessing h5p.org to h5p.com

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              vmdef Victor Déniz Falcón
              stronk7 Eloy Lafuente (stronk7)
              Amaia Anabitarte Amaia Anabitarte
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/Mar/20

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 days, 5 hours, 15 minutes
                  3d 5h 15m