Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Blocker
-
Resolution: Fixed
-
Affects Version/s: 3.8, 3.8.2, 3.9
-
Fix Version/s: 3.8.3
-
Component/s: Automated functional tests (behat)
-
Testing Instructions:
-
Affected Branches:MOODLE_38_STABLE, MOODLE_39_STABLE
-
Fixed Branches:MOODLE_38_STABLE
-
Epic Link:
-
Pull from Repository:
-
Pull 3.8 Branch:
MDL-67317_38 -
Pull 3.8 Diff URL:
-
Pull Master Branch:
-
Pull Master Diff URL:
Description
Once the main problems in core has been solved, behat runs have revealed that current mink 1.7.1 is not php74 compliant.
See: https://travis-ci.org/stronk7/Mink/builds/614672369
That matches the errors we are getting in our runs:
007 Scenario: Moving chapters up rearranges them properly # /var/www/html/mod/book/tests/behat/reorganize_chapters.feature:62
|
Given I click on "Move chapter up \"3. There aren't 2 without 3\"" "link" # /var/www/html/mod/book/tests/behat/reorganize_chapters.feature:63
|
8192: implode(): Passing glue string after array is deprecated. Swap the parameters in /var/www/html/vendor/behat/mink/src/Selector/Xpath/Escaper.php line 50
|
This is about to send a PR to them, asking for a quick 1.7.2 if possible (if not, we'll need to fork and point to ours).
WIP fix/PR: https://github.com/minkphp/Mink/pull/792
That makes their own tests to pass:
https://travis-ci.org/stronk7/Mink/builds/614678756
Ciao