Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67317

behat/mink is not php74 compliant

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      100% automated (can be left to CiBoT once #1 and #4 have been verified):

      1. Verify that travis is passing for the branches.
      2. Verify that CI jobs are passing.
      3. Look to the jobs @ the 7.4 epic description (they include the changes performed by this issue and run using php74).
      4. Verify they are passing.
      • Passing = passing or unstable (randoms)
      Show
      100% automated (can be left to CiBoT once #1 and #4 have been verified): Verify that travis is passing for the branches. Verify that CI jobs are passing. Look to the jobs @ the 7.4 epic description (they include the changes performed by this issue and run using php74). Verify they are passing. Passing = passing or unstable (randoms)
    • Affected Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      Once the main problems in core has been solved, behat runs have revealed that current mink 1.7.1 is not php74 compliant.

      See: https://travis-ci.org/stronk7/Mink/builds/614672369

      That matches the errors we are getting in our runs:

      007 Scenario: Moving chapters up rearranges them properly                       # /var/www/html/mod/book/tests/behat/reorganize_chapters.feature:62
      		 
            Given I click on "Move chapter up \"3. There aren't 2 without 3\"" "link" # /var/www/html/mod/book/tests/behat/reorganize_chapters.feature:63
      		 
              8192: implode(): Passing glue string after array is deprecated. Swap the parameters in /var/www/html/vendor/behat/mink/src/Selector/Xpath/Escaper.php line 50

      This is about to send a PR to them, asking for a quick 1.7.2 if possible (if not, we'll need to fork and point to ours).

      WIP fix/PR: https://github.com/minkphp/Mink/pull/792

      That makes their own tests to pass:

      https://travis-ci.org/stronk7/Mink/builds/614678756

      Ciao

        Attachments

          Issue Links

          blocks

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-66263 Bump Travis max version to 7.4

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-68445 Bump to current (3.6.x) behat version

          • Minor - Minor loss of function where workaround is possible
          • Closed
          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-68525 Behat broken since MDL-67317 + Chrome 81 using $CFG->behat_profiles as in the docs

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              stronk7 Eloy Lafuente (stronk7)
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Peer reviewer:
              Tim Hunt Tim Hunt
              Integrator:
              Andrew Lyons Andrew Lyons
              Tester:
              CiBoT CiBoT
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/20

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 10 minutes
                  3h 10m