[MDL-67317] behat/mink is not php74 compliant - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: 3.8, 3.8.2, 3.9
Fix Version/s: 3.8.3
Component/s: Automated functional tests (behat)
Labels:
- ci
- triaged

Testing Instructions:
Hide

100% automated (can be left to CiBoT once #1 and #4 have been verified):

Verify that travis is passing for the branches.

Verify that CI jobs are passing.

Look to the jobs @ the 7.4 epic description (they include the changes performed by this issue and run using php74).

Verify they are passing.

Passing = passing or unstable (randoms)
Show
100% automated (can be left to CiBoT once #1 and #4 have been verified): Verify that travis is passing for the branches. Verify that CI jobs are passing. Look to the jobs @ the 7.4 epic description (they include the changes performed by this issue and run using php74). Verify they are passing. Passing = passing or unstable (randoms)
Affected Branches:
MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_38_STABLE
Epic Link:
Prepare Moodle for PHP 7.4
Pull from Repository:
https://github.com/stronk7/moodle.git
Pull 3.8 Branch:
~~MDL-67317~~_38
Pull 3.8 Diff URL:
https://github.com/stronk7/moodle/compare/MDL-67317_38~2...MDL-67317_38
Pull Master Branch:
~~MDL-67317~~
Pull Master Diff URL:
https://github.com/stronk7/moodle/compare/MDL-67317~2...MDL-67317

Description

Once the main problems in core has been solved, behat runs have revealed that current mink 1.7.1 is not php74 compliant.

See: https://travis-ci.org/stronk7/Mink/builds/614672369

That matches the errors we are getting in our runs:

007 Scenario: Moving chapters up rearranges them properly                       # /var/www/html/mod/book/tests/behat/reorganize_chapters.feature:62

      Given I click on "Move chapter up \"3. There aren't 2 without 3\"" "link" # /var/www/html/mod/book/tests/behat/reorganize_chapters.feature:63

        8192: implode(): Passing glue string after array is deprecated. Swap the parameters in /var/www/html/vendor/behat/mink/src/Selector/Xpath/Escaper.php line 50

This is about to send a PR to them, asking for a quick 1.7.2 if possible (if not, we'll need to fork and point to ours).

WIP fix/PR: https://github.com/minkphp/Mink/pull/792

That makes their own tests to pass:

https://travis-ci.org/stronk7/Mink/builds/614678756

Ciao

Attachments

Issue Links

blocks

MDL-66263 Bump Travis max version to 7.4

Closed

MDL-68445 Bump to current (3.6.x) behat version

Closed

caused a regression

MDL-68525 Behat broken since MDL-67317 + Chrome 81 using $CFG->behat_profiles as in the docs

Closed

Activity

People

Assignee:: Eloy Lafuente (stronk7)

Reporter:: Eloy Lafuente (stronk7)

Peer reviewer:: Tim Hunt

Integrator:: Andrew Nicols

Tester:: CiBoT

Participants:: Andrew Nicols, CiBoT, Eloy Lafuente (stronk7), Matteo Scaramuccia, Tim Hunt

Component watchers:: Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 21/Nov/19 3:07 AM

Updated:: 1 week ago 2:41 AM

Resolved:: 24/Apr/20 10:14 AM

Fix Release Date:: 11/May/20

Time Tracking

Estimated:

Remaining:

Logged:

3h 10m