Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67348

Performance regression in css delivery

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Blocker Blocker
    • 3.8.1
    • 3.8, 3.8 regressions
    • Performance, Themes
    • MOODLE_38_STABLE
    • MOODLE_38_STABLE
    • MDL-67348-master
    • Hide

      This is really difficult to test because it's all to do with caching.

      I would suggest that a developer be assigned testing of this issue and add some calls to error_log into theme/styles.php to display which file is being served, and from where, and when we start to generate it again.

      Show
      This is really difficult to test because it's all to do with caching. I would suggest that a developer be assigned testing of this issue and add some calls to error_log into theme/styles.php to display which file is being served, and from where, and when we start to generate it again.

      We removed the CSS Chunker required for IE <=9 in MDL-55751, but in doing so we also removed the bypass of CSS generation.

      Whilst we do not actually generate the CSS any more often, we do unnecessarily connect to the DB, and load up cache definitions, and then serve from the cache when the file is already available on disk. This will only be the first time each browser connects but that's still a massive performance regression.

        1. check_before_patch.png
          check_before_patch.png
          28 kB
        2. check_after_patch.png
          check_after_patch.png
          28 kB

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Adrian Greeve Adrian Greeve
            Shamim Rezaie Shamim Rezaie
            Votes:
            3 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours, 50 minutes
                4h 50m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.