Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67348

Performance regression in css delivery

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.8, 3.8 regressions
    • Fix Version/s: 3.8.1
    • Component/s: Performance, Themes
    • Labels:
    • Testing Instructions:
      Hide

      This is really difficult to test because it's all to do with caching.

      I would suggest that a developer be assigned testing of this issue and add some calls to error_log into theme/styles.php to display which file is being served, and from where, and when we start to generate it again.

      Show
      This is really difficult to test because it's all to do with caching. I would suggest that a developer be assigned testing of this issue and add some calls to error_log into theme/styles.php to display which file is being served, and from where, and when we start to generate it again.
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull Master Branch:
      MDL-67348-master

      Description

      We removed the CSS Chunker required for IE <=9 in MDL-55751, but in doing so we also removed the bypass of CSS generation.

      Whilst we do not actually generate the CSS any more often, we do unnecessarily connect to the DB, and load up cache definitions, and then serve from the cache when the file is already available on disk. This will only be the first time each browser connects but that's still a massive performance regression.

        Attachments

        1. check_after_patch.png
          28 kB
          Axel Kloss
        2. check_before_patch.png
          28 kB
          Axel Kloss

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Lyons
              Reporter:
              dobedobedoh Andrew Lyons
              Peer reviewer:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Integrator:
              Adrian Greeve Adrian Greeve
              Tester:
              Shamim Rezaie Shamim Rezaie
              Participants:
              Component watchers:
              Matteo Scaramuccia, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Huong Nguyen, Bas Brands, Mathew May
              Votes:
              3 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Jan/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours, 50 minutes
                  4h 50m