Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67386

Upgrade boost to use Bootstrap v4.5.0

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Use 2 Moodle instances, one based on the integration branch including this patch, one on latests master. In both instances take these steps:

      Testing scenario 1: Test if all Boostrap JavaScript works

      1. Login as Admin
      2. Create a course C1
      3. Restore the attached backup to course C1
      4. Compare the restored book page by page with the other Moodle instance
      5. Verify the book content looks the same on both instances
      6. Verify the JS functionality works for: Alerts (dismiss), Buttons (remember state), Carousel (slide), Dropdown (show menu), Popover (show popover). Tooltips (show tooltip)
      7. Access to your apache logs (they use to be placed at /var/log/apache2/error.log) and check that there are no sass parse errors there.

      Testing scenario 2: Check logs

      1. Login as Admin
      2. Navigate to Site Administration -> Development -> Debugging
      3. Choose Developer.. at Debug messages
      4. Tick the Display debug messages checkbox
      5. Open a console showing your web server / PHP log files (they use to be placed at /var/log/apache2/access.log and /var/log/apache2/error.log)
      6. Navigate to Site Administration -> Development -> Purge Caches
      7. Navigate to the Site Homepage
      8. Wait for the page to load and rebuild caches
      9. Check log files (access.log and error.log) doesn't contain errors.
      Show
      Use 2 Moodle instances, one based on the integration branch including this patch, one on latests master. In both instances take these steps: Testing scenario 1: Test if all Boostrap JavaScript works Login as Admin Create a course C1 Restore the attached backup to course C1 Compare the restored book page by page with the other Moodle instance Verify  the book content looks the same on both instances Verify the JS functionality works for: Alerts (dismiss), Buttons (remember state), Carousel (slide), Dropdown (show menu), Popover (show popover). Tooltips (show tooltip) Access to your apache logs (they use to be placed at /var/log/apache2/error.log) and check that there are no sass parse errors there. Testing scenario 2: Check logs Login as Admin Navigate to Site Administration -> Development -> Debugging Choose Developer.. at Debug messages Tick the Display debug messages checkbox Open a console showing your web server / PHP log files (they use to be placed at /var/log/apache2/access.log and /var/log/apache2/error.log) Navigate to Site Administration -> Development -> Purge Caches Navigate to the Site Homepage Wait for the page to load and rebuild caches Check  log files (access.log and error.log) doesn't contain errors.
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      MDL-67386-master-hotfix

      Description

      Twitter Bootstrap (/theme/boost/scss/bootstrap/) 4.3.1 --> 4.4.0: https://github.com/twitter/bootstrap.git 
       

        Attachments

        1. 1userenrolled.png
          1userenrolled.png
          72 kB
        2. backup-moodle2-activity-101-book101-20190715-1718-nu.mbz
          8 kB
        3. Screenshot_1.png
          Screenshot_1.png
          243 kB
        4. Screenshot_2.png
          Screenshot_2.png
          481 kB
        5. validation.png
          validation.png
          87 kB

          Issue Links

            Activity

              People

              Assignee:
              basbrands Bas Brands
              Reporter:
              sarjona Sara Arjona (@sarjona)
              Peer reviewer:
              Carlos Escobedo
              Integrator:
              Sara Arjona (@sarjona)
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jun/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 days, 50 minutes
                  3d 50m