Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67387

Upgrade PHPSpreadsheet to latest version

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Waiting for integration review
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.8
    • Fix Version/s: None
    • Component/s: Libraries
    • Testing Instructions:
      Hide

      Testing scenario 1

      1. Login as admin
      2. Go to http://yourmoodleurl/lib/tests/other/spreadsheettestpage.php and generate the Excel sample file.
      3. Review the server error logs to make sure there are no notices there.
      4. Open the Excel sample file in various office suites.
      5. Expected Result: Check the content is displayed as expected. You can download the ODS file and compare with it or download the Excel file without that patch. Alternatively, you can also compare to the moodletest_withoutpatch.xlsx attached file (which was created without the patch).

       

      Testing scenario 2

      1. Login as admin.
      2. Create a course with some enrolled students and one graded activity for some of them (at least).
      3. Access to the course.
      4. Go to Grades / Export / Excel spreadsheet
      5. Click over the Download button
      6. Expected Result: Check the file is downloaded and contains one row per user and, at least, the following columns:  "First name", "Surname", "ID number", "Institution", "Department", "Email address", "Course total", "Last downloaded from this course" and one column for each activity.
      Show
      Testing scenario 1 Login as admin Go to  http://yourmoodleurl/lib/tests/other/spreadsheettestpage.php  and generate the Excel sample file. Review the server error logs to make sure there are no notices there. Open the Excel sample file in various office suites. Expected Result: Check the content is displayed as expected. You can download the ODS file and compare with it or download the Excel file without that patch. Alternatively, you can also compare to the moodletest_withoutpatch.xlsx  attached file (which was created without the patch).   Testing scenario 2 Login as admin. Create a course with some enrolled students and one graded activity for some of them (at least). Access to the course. Go to Grades / Export / Excel spreadsheet Click over the Download button Expected Result: Check the file is downloaded and contains one row per user and, at least, the following columns:  "First name", "Surname", "ID number", "Institution", "Department", "Email address", "Course total", "Last downloaded from this course" and one column for each activity.
    • Affected Branches:
      MOODLE_38_STABLE
    • Epic Link:
    • Pull Master Branch:
      MDL-67387-master
    • Sprint:
      Moodle 3.9 - Moppies Kanban

      Description

      PhpSpreadsheet (/lib/phpspreadsheet/) 1.07.0 --> 1.10.0: https://github.com/PHPOffice/PhpSpreadsheet/releases 

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 30 minutes
                  5h 30m