Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67392

Forum information about timed discussion doesn't handle correctly "displaystartdate" and "displayenddate" containing quotes

    XMLWordPrintable

Details

    • MOODLE_38_STABLE
    • MOODLE_38_STABLE
    • MDL-67392-master
    • Hide
      1. Log in as admin
      2. Make a language customisation of "Forum" component, and modify "displaystartdate" with "It's display start: {$a}." and "displayenddate" to "It's display end: {$a}." and save modifications
      3. Create a new course or go into an existing one
      4. Create a forum using default settings
      5. Click on the "Add a new discussion topic" button
      6. Click on the "Advanced" link
      7. Type something in the "subject" and in the "message" fields.
      8. Expand the "Display period" section and set a "Display start" and "Display end" date
      9. Save.
      10. Verify that forum list of discussions well shows the "Timed" label
      11. Click on the "Timed" label
      12. Verify that you see information about the "display start" and "display end" of the discussion
      Show
      Log in as admin Make a language customisation of "Forum" component, and modify "displaystartdate" with "It's display start: {$a}." and "displayenddate" to "It's display end: {$a}." and save modifications Create a new course or go into an existing one Create a forum using default settings Click on the "Add a new discussion topic" button Click on the "Advanced" link Type something in the "subject" and in the "message" fields. Expand the "Display period" section and set a "Display start" and "Display end" date Save. Verify that forum list of discussions well shows the "Timed" label Click on the "Timed" label Verify that you see information about the "display start" and "display end" of the discussion
    • 1

    Description

      MDL-66481 introduced showing a "Timed" label next to timed discussions.

      But if "displaystartdate" or "displayenddate" contains quote (it's the case at least for french), the "Timed" label is broken.

      You can look at the discussion https://moodle.org/mod/forum/discuss.php?d=393804 for details.

      To replicate :

      1. create in a forum a timed discussion (tick display start and end dates)
      2. verify that forum list of discussions well shows the "Timed" label
      3. make a language customisation of "Forum" component, and modify "displaystartdate" with "It's display start: {$a}." and "displayenddate" to "It's display end: {$a}." and save modifications
      4. verify again forum list of discussions. It should still well show the "Timed" label, but it's not the case

       

      Attachments

        Issue Links

          Activity

            People

              rezaie9 Shamim Rezaie
              fox Séverin Terrier
              Peter Dias Peter Dias
              Jake Dallimore Jake Dallimore
              Gladys Basiana Gladys Basiana
              Votes:
              3 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                13/Jan/20

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 41 minutes
                  3h 41m