Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67394

Improve error reporting when Oracle fails to parse query

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.8, 3.9.1, 3.10
    • Fix Version/s: 3.8.5, 3.9.2
    • Component/s: Database SQL/XMLDB
    • Labels:

      Description

      The information included in the exception thrown when oci_parse fails in the Oracle DML parse_query method could be improved (see also the TODO): https://github.com/moodle/moodle/blob/a5f618d6a988547c31da73f2e5fff48c48c776fb/lib/dml/oci_native_moodle_database.php#L346-L358

      I hit an exception in a unit test for Workplace that simply stated: "Can not parse sql query"

        Attachments

        1. after.png
          after.png
          40 kB
        2. before.png
          before.png
          49 kB
        3. image-2020-08-13-10-56-37-927.png
          image-2020-08-13-10-56-37-927.png
          43 kB
        4. MDL-67394.php
          0.2 kB

          Activity

            People

            Assignee:
            pholden Paul Holden
            Reporter:
            pholden Paul Holden
            Peer reviewer:
            David Matamoros
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Janelle Barcega
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              14/Sep/20

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 40 minutes
                40m