Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.8, 3.9.1, 3.10
-
Component/s: Database SQL/XMLDB
-
Labels:
-
Database:Oracle
-
Testing Instructions:
- Install a site with Oracle
- Place MDL-67394.php
in site dirroot - Navigate to this test file in a browser
- Confirm thrown exception states: "Error parsing SQL query"
- Confirm debug info states: "ORA-01756: quoted string not properly terminated"
Note: we aren't testing whether the SQL is valid (it isn't), just that when oci_parse() fails we throw an appropriate/helpful exception
Install a site with Oracle Place MDL-67394.php in site dirroot Navigate to this test file in a browser Confirm thrown exception states: "Error parsing SQL query" Confirm debug info states: "ORA-01756: quoted string not properly terminated" Note: we aren't testing whether the SQL is valid (it isn't), just that when oci_parse() fails we throw an appropriate/helpful exception -
Affected Branches:MOODLE_310_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
-
Fixed Branches:MOODLE_38_STABLE, MOODLE_39_STABLE
-
Pull from Repository:
-
Pull 3.8 Branch:
MDL-67394-38 -
Pull 3.9 Branch:
MDL-67394-39 -
Pull Master Branch:
-
Pull Master Diff URL:
Description
The information included in the exception thrown when oci_parse fails in the Oracle DML parse_query method could be improved (see also the TODO): https://github.com/moodle/moodle/blob/a5f618d6a988547c31da73f2e5fff48c48c776fb/lib/dml/oci_native_moodle_database.php#L346-L358
I hit an exception in a unit test for Workplace that simply stated: "Can not parse sql query"
