Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67417

Tooltip/Help icon stop working after closing using escape key.

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.7.4, 3.8.1
    • 3.7.3, 3.8
    • JavaScript
    • MOODLE_37_STABLE, MOODLE_38_STABLE
    • MOODLE_37_STABLE, MOODLE_38_STABLE
    • MDL-67417-master
    • Hide

      Step to reproduce:

      1. Log in as administrator
      2. Navigate to Site administration -> Courses -> Create a new course
      3. Click on the help icon for "Course full name"
        1. Confirm that the help is shown
      4. Press the "Escape" key
        1. Confirm that the help was hidden
      5. Click on the same help icon again
        1. Confirm that the help is shown
      Show
      Step to reproduce: Log in as administrator Navigate to Site administration -> Courses -> Create a new course Click on the help icon for "Course full name" Confirm that the help is shown Press the "Escape" key Confirm that the help was hidden Click on the same help icon again Confirm that the help is shown

      Step to reproduce:

      1. Go to any page that having help icon (e.g: Create course page).
      2. Click on help icon, help dialog will be opened.
      3. Close dialog using "Escape" key.
      4. Click on the same help icon again, now we cannot open the help dialog.

       

      Note: It's still working if we close the dialog by using tab key or click anywhere on the page.

       

      Update:

      Change the line theme/boost/amd/src/loader.js:56

      From 

      jQuery('body').on(customEvents.events.escape, '[data-toggle=popover]', function() {
          jQuery(this).popover('hide');
      });

      To

      jQuery('body').on(customEvents.events.escape, '[data-toggle=popover]', function() {
          jQuery(this).trigger('blur');
      });
      

      Seem to fix the issue, I'm checking if it causes any side effect.

        1. Demo.gif
          Demo.gif
          62 kB
        2. MDL-67417.jpg
          MDL-67417.jpg
          31 kB

            kietlyc Kiet Ly
            kietlyc Kiet Ly
            Andrew Lyons Andrew Lyons
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Anna Carissa Sadia Anna Carissa Sadia
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 45 minutes
                45m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.