Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67417

Tooltip/Help icon stop working after closing using escape key.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.7.3, 3.8
    • Fix Version/s: 3.7.4, 3.8.1
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      Step to reproduce:

      1. Log in as administrator
      2. Navigate to Site administration -> Courses -> Create a new course
      3. Click on the help icon for "Course full name"
        1. Confirm that the help is shown
      4. Press the "Escape" key
        1. Confirm that the help was hidden
      5. Click on the same help icon again
        1. Confirm that the help is shown
      Show
      Step to reproduce: Log in as administrator Navigate to Site administration -> Courses -> Create a new course Click on the help icon for "Course full name" Confirm that the help is shown Press the "Escape" key Confirm that the help was hidden Click on the same help icon again Confirm that the help is shown
    • Affected Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Pull Master Branch:
      MDL-67417-master

      Description

      Step to reproduce:

      1. Go to any page that having help icon (e.g: Create course page).
      2. Click on help icon, help dialog will be opened.
      3. Close dialog using "Escape" key.
      4. Click on the same help icon again, now we cannot open the help dialog.

       

      Note: It's still working if we close the dialog by using tab key or click anywhere on the page.

       

      Update:

      Change the line theme/boost/amd/src/loader.js:56

      From 

      jQuery('body').on(customEvents.events.escape, '[data-toggle=popover]', function() {
          jQuery(this).popover('hide');
      });

      To

      jQuery('body').on(customEvents.events.escape, '[data-toggle=popover]', function() {
          jQuery(this).trigger('blur');
      });
      

      Seem to fix the issue, I'm checking if it causes any side effect.

        Attachments

        1. MDL-67417.jpg
          MDL-67417.jpg
          31 kB
        2. Demo.gif
          Demo.gif
          62 kB

          Activity

            People

            Assignee:
            kietlyc Kiet Ly
            Reporter:
            kietlyc Kiet Ly
            Peer reviewer:
            Andrew Lyons Andrew Lyons
            Integrator:
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Tester:
            Anna Carissa Sadia Anna Carissa Sadia
            Participants:
            Component watchers:
            Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/Jan/20

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 45 minutes
                45m