Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67422

clarify / unify calendar permissions evaluation

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.7.3, 3.8, 3.9
    • Fix Version/s: None
    • Component/s: Calendar, Roles / Access
    • Labels:
    • Affected Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE

      Description

      This was considered when reviewing MDL-67300.

      Right now calendar has different methods deciding which type of events can be managed at every context. And it seems that they are used in a mixed way.

      A proposal to unify uses a little more way done there, see this commit:

      https://github.com/lameze/moodle/commit/44dad9ee5f0fd07f08fc593ef2fd6a5c18a3998d

      And it was a good step, but this issue is a little bit more ambitious:

      1) We should review all the methods within calendar that have responsibilities calculating permissions.

      2) We should unify uses as much as possible, clearly deprecating the methods that we consider "old".

      3) All the combinations should be well covered by automation tests.

      4) The methods should be well documented (phpdoc is ok), about which are they correct uses and so on.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated: