Loading...

XML

Word

Printable

Details

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 3.11.6
Affects Version/s: 3.5.9, 3.6.7, 3.7.3, 3.8, 3.9.12, 3.11.5, 4.0
Component/s: Filters, Navigation
Labels:
- CatalystIT
- ci
- partner
- partner-Praxis
- release_notes
- triaged

Affected Branches:
MOODLE_311_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_311_STABLE
Pull from Repository:
https://github.com/Peterburnett/moodle
Pull Main Branch:
~~MDL-67428~~-filter-context
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...Peterburnett:MDL-67428-filter-context
Testing Instructions:
Hide

Prerequisites:

1) Visit Site Administration -> Debugging settings at /admin/settings.php?section=debugging

Enable 'Performance info'

2) Visit Site Administration -> Plugins -> Filters -> Manage filters

Ensure 'Activity names auto linking' and 'Display H5P' are both on

Switch both of these filters to apply to 'Content and headings'

Testing

Visit Site Administration->Course->Course and category management - /course/management.php

Click Create new Category

Ensure Parent Category is the default 'Category 1'

Name this 'Subcategory 1' and click Create category

Click Create new Category again

Ensure parent category is 'Subcategory 1'

Name this category 'Subcategory 2' and click Create category

Click Create new course

Ensure the category is within Subcategory 2

Fill the form in with 'test' as the name and shortname, then click Save and Return

View the performance footer, and take note of the amount of 'Contexts for which filters were loaded' such as 9

In another tab, open Site Administration->Plugins->Filters->Common filter settings - /admin/settings.php?section=commonfiltersettings

Enable 'Filter navigation with system context' and click Save changes

Reload the course management page

Confirm the 'Contexts for which filters were loaded' in the footer is 4 fewer, eg 5, the difference is the number of courses and categories no longer loaded into navigation.
Show
Prerequisites: 1) Visit Site Administration -> Debugging settings at /admin/settings.php?section=debugging Enable 'Performance info' 2) Visit Site Administration -> Plugins -> Filters -> Manage filters Ensure ' Activity names auto linking' and 'Display H5P' are both on Switch both of these filters to apply to 'Content and headings' Testing Visit Site Administration->Course->Course and category management - /course/management.php Click Create new Category Ensure Parent Category is the default 'Category 1' Name this ' Subcategory 1 ' and click Create category Click Create new Category again Ensure parent category is 'Subcategory 1' Name this category ' Subcategory 2 ' and click Create category Click Create new course Ensure the category is within Subcategory 2 Fill the form in with 'test' as the name and shortname, then click Save and Return View the performance footer, and take note of the amount of ' Contexts for which filters were loaded ' such as 9 In another tab, open Site Administration->Plugins->Filters->Common filter settings - /admin/settings.php?section=commonfiltersettings Enable 'Filter navigation with system context' and click Save changes Reload the course management page Confirm the 'Contexts for which filters were loaded' in the footer is 4 fewer , eg 5, the difference is the number of courses and categories no longer loaded into navigation.

Description

We have several customers who have quite expansive categories lists of courses, and naturally if you're on a course, the navigation will build the tree down to the point you're at, and typically will apply filters as well.

The problem we're seeing is that the navigation will apply the filtering by context and need to fetch many separate contexts to work out the filtering - in some cases this has amounted to hundreds of lookups to fetch filters.

I'm wondering if the solution to this problem is to have the navigation system only ever treat the filters as coming from the system context (or, instead, have this as an option) since if you're using multilang on titles, you probably need it at all contexts anyway (therefore having it in the system context doesn't make things significantly worse)

The worst cases for us are when users take a quiz and the quiz ends up producing hundreds of queries form each user for each page load, just to fetch the filters.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-67428_master.webm
2.37 MB
10/Mar/22 1:55 PM
MDL-67428_v311.webm
2.25 MB
10/Mar/22 1:55 PM

Issue Links

blocks

MDL-73804 make_categories_list is extremely slow when performing course management

Closed

has a non-specific relationship to

MDL-68441 Active filters are not cached leading to uneccessary queries on each page load

Open

Activity

People

Assignee:: Peter Burnett

Reporter:: Peter Spicer

Peer reviewer:: Brendan Heywood

Integrator:: Ilya Tregubov

Tester:: Angelia Dela Cruz

Participants:: Alexander Bias, Alistair Spark, Angelia Dela Cruz, Brendan Heywood, CiBoT, Eloy Lafuente (stronk7), Ilya Tregubov, Matt Porritt, Neill Magill, Peter Burnett, Peter Spicer, Tue Korsgaard

Votes:: 3 Vote for this issue

Watchers:: 14 Start watching this issue

Dates

Created:: 02/Dec/19 9:52 PM

Updated:: 11/Mar/22 7:22 PM

Resolved:: 11/Mar/22 7:22 PM

Fix Release Date:: 14/Mar/22

Time Tracking

Estimated:

Remaining:

Logged:

1h 10m