Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67438

Coding style cleanup: mod/wiki/parser/parser.php

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.7.3, 3.8, 3.9
    • Fix Version/s: 3.9
    • Component/s: General, Wiki (2.x)
    • Labels:

      Description

      This is about to clean mod/wiki/parser/parser.php and make it style compliant:

      • Add the file comments block (+ MOODLE_INTERNAL).
      • Whitespace fixes (alignment, tabs, trailing...)
      • Rename a couple of (internal) variables to follow the coding style.

      Note this does not fix the missing (in all methods) phpdoc blocks. Only phpcs.

      We don't touch this file much, but every time we do lots of those little things are reported (for example MDL-67114). I started applying the coding style in that issue but wanted to keep that it clean from noise. So doing it here and now.

      For your consideration.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              stronk7 Eloy Lafuente (stronk7)
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Peer reviewer:
              Simey Lameze
              Integrator:
              Adrian Greeve
              Tester:
              CiBoT
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jun/20

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 50 minutes
                  1h 50m