[MDL-67442] Assignment online text and feedback comments don't expand using Safari - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.6.7, 3.7.3, 3.8, 3.9
Fix Version/s: 3.7.6, 3.8.3
Component/s: Assignment
Labels:
- ci
- release_notes
Environment:
Safari 13.0.3 (macOS 10.14), Mobile Safari (iOS 13.2.2, 12.4)

Affected Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE
Pull from Repository:
https://github.com/jonof/moodle.git
Pull Main Branch:
~~MDL-67442~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...jonof:MDL-67442
Testing Instructions:
Hide

Using each supported browser, and bootstrapbase and boost-derived themes as applicable:

Create an Assignment activity with 'Online text' submission type and 'Feedback comments' feedback type enabled.

Submit for/as a student and enter lengthy text, enough for it to be abbreviated.

Grade the student submission. Check that the submitted text can be expanded and collapsed.

Enter lengthy feedback text, enough for it to be abbreviated, and save.

Log-in as the student and view the Assignment activity.

Check that the submitted text can be expanded and collapsed.

Check that the feedback text can be expanded and collapsed.
Show
Using each supported browser, and bootstrapbase and boost-derived themes as applicable: Create an Assignment activity with 'Online text' submission type and 'Feedback comments' feedback type enabled. Submit for/as a student and enter lengthy text, enough for it to be abbreviated. Grade the student submission. Check that the submitted text can be expanded and collapsed. Enter lengthy feedback text, enough for it to be abbreviated, and save. Log-in as the student and view the Assignment activity. Check that the submitted text can be expanded and collapsed. Check that the feedback text can be expanded and collapsed.

Description

An Assignment submission with lengthy 'Online text' and/or 'Feedback comments' does not expand or contract those abbreviated text blocks (either in the grading app or on the submission status view) using Safari on macOS or iOS.

Under Webkit, the CSS "pointer-events: none" on the i/img element prevents the click from bubbling to the enclosing anchor element. The most compatible solution is to use the `currentTarget` property of the JavaScript event instead of `target` and not disable pointer events from CSS.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

image-2020-03-26-10-05-25-799.png
295 kB
26/Mar/20 10:05 AM

Issue Links

is a regression caused by

MDL-61121 Assignment accessibility correct use of tables and toggleable +/- link

Closed

is duplicated by

MDL-68035 Assign plugin feedback not expanding in Safari

Closed

Activity

People

Assignee:: Jonathon Fowler

Reporter:: Jonathon Fowler

Peer reviewer:: Simey Lameze

Integrator:: Eloy Lafuente (stronk7)

Tester:: Janelle Barcega

Participants:: CiBoT, Eloy Lafuente (stronk7), Howard Miller, Janelle Barcega, Jonathon Fowler, Marco Bonfieni (CSC), Matteo Scaramuccia, Mike Wilday, paul vella, Sanna Parikka, Sergio Comerón, Simey Lameze, Steve Radford

Votes:: 20 Vote for this issue

Watchers:: 25 Start watching this issue

Dates

Created:: 04/Dec/19 7:52 AM

Updated:: 15/Nov/22 5:24 PM

Resolved:: 27/Mar/20 9:45 AM

Fix Release Date:: 11/May/20

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

2h 15m