Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67442

Assignment online text and feedback comments don't expand using Safari

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 3.6.7, 3.7.3, 3.8, 3.9
    • 3.7.6, 3.8.3
    • Assignment
    • Safari 13.0.3 (macOS 10.14), Mobile Safari (iOS 13.2.2, 12.4)
    • MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • MOODLE_37_STABLE, MOODLE_38_STABLE
    • Hide

      Using each supported browser, and bootstrapbase and boost-derived themes as applicable:

      1. Create an Assignment activity with 'Online text' submission type and 'Feedback comments' feedback type enabled.
      2. Submit for/as a student and enter lengthy text, enough for it to be abbreviated.
      3. Grade the student submission. Check that the submitted text can be expanded and collapsed.
      4. Enter lengthy feedback text, enough for it to be abbreviated, and save.
      5. Log-in as the student and view the Assignment activity.
      6. Check that the submitted text can be expanded and collapsed.
      7. Check that the feedback text can be expanded and collapsed.
      Show
      Using each supported browser, and bootstrapbase and boost-derived themes as applicable: Create an Assignment activity with 'Online text' submission type and 'Feedback comments' feedback type enabled. Submit for/as a student and enter lengthy text, enough for it to be abbreviated. Grade the student submission. Check that the submitted text can be expanded and collapsed. Enter lengthy feedback text, enough for it to be abbreviated, and save. Log-in as the student and view the Assignment activity. Check that the submitted text can be expanded and collapsed. Check that the feedback text can be expanded and collapsed.

    Description

      An Assignment submission with lengthy 'Online text' and/or 'Feedback comments' does not expand or contract those abbreviated text blocks (either in the grading app or on the submission status view) using Safari on macOS or iOS.

      Under Webkit, the CSS "pointer-events: none" on the i/img element prevents the click from bubbling to the enclosing anchor element. The most compatible solution is to use the `currentTarget` property of the JavaScript event instead of `target` and not disable pointer events from CSS.

      Attachments

        Issue Links

          Activity

            People

              jonof Jonathon Fowler
              jonof Jonathon Fowler
              Simey Lameze Simey Lameze
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Janelle Barcega Janelle Barcega
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan
              Votes:
              20 Vote for this issue
              Watchers:
              24 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                11/May/20

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 15 minutes
                  2h 15m