Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67468

Static properties of filter_activitynames class should be reset after unit tests

    XMLWordPrintable

    Details

      Description

      When running unit tests in parallel these failures might be caught:

       

      1)
      filter_activitynames_filter_testcase::test_links
      Failed asserting that 0 matches expected 2.
       
      /siteroot/filter/activitynames/tests/filter_test.php:63
      /siteroot/lib/phpunit/classes/advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit "filter_activitynames_filter_testcase" filter/activitynames/tests/filter_test.php
      

       

      1)
      filter_glossary_filter_testcase::test_brackets
      Failed asserting that 2 matches expected 3.
       
      /siteroot/filter/glossary/tests/filter_test.php:230
      /siteroot/lib/phpunit/classes/advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit "filter_glossary_filter_testcase" filter/glossary/tests/filter_test.php
      

       

      Commands to replicate:

      ./vendor/bin/phpunit --testsuite filter_activitynames_testsuite,filter_glossary_testsuite
      

      ./vendor/bin/phpunit --testsuite core_grades_testsuite,filter_activitynames_testsuite
      

       

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Nguyen Nathan Nguyen
              Reporter:
              mikhailgolenkov Mikhail Golenkov
              Peer reviewer:
              Eloy Lafuente (stronk7)
              Integrator:
              Sara Arjona (@sarjona)
              Tester:
              Gladys Basiana
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              2 Vote for this issue
              Watchers:
              9 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Sep/20

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours, 55 minutes
                  4h 55m