Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67468

Static properties of filter_activitynames class should be reset after unit tests

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Reopened
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.7.3, 3.8, 3.9
    • Fix Version/s: None
    • Component/s: Filters, Unit tests
    • Testing Instructions:
      Hide

      1. Run unit test for filter_activitynames_testsuite and filter_glossary_testsuite test suites in one go:

      ./vendor/bin/phpunit --testsuite filter_activitynames_testsuite,filter_glossary_testsuite
      

      2. Confirm that there are no errors or failures.

      3. Run unit test for core_grades_testsuite and filter_activitynames_testsuite test suites in one go:

      ./vendor/bin/phpunit --testsuite core_grades_testsuite,filter_activitynames_testsuite
      

       4. Confirm that there are no errors or failures.

      Show
      1. Run unit test for filter_activitynames_testsuite and filter_glossary_testsuite test suites in one go: ./vendor/bin/phpunit --testsuite filter_activitynames_testsuite,filter_glossary_testsuite 2. Confirm that there are no errors or failures. 3. Run unit test for core_grades_testsuite and filter_activitynames_testsuite test suites in one go: ./vendor/bin/phpunit --testsuite core_grades_testsuite,filter_activitynames_testsuite  4. Confirm that there are no errors or failures.
    • Affected Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • Pull from Repository:
    • Pull 3.7 Branch:
      MOODLE_37_MDL-67468
    • Pull 3.8 Branch:
      MOODLE_38_MDL-67468
    • Pull Master Branch:
      master_MDL-67468

      Description

      When running unit tests in parallel these failures might be caught:

       

      1)
      filter_activitynames_filter_testcase::test_links
      Failed asserting that 0 matches expected 2.
       
      /siteroot/filter/activitynames/tests/filter_test.php:63
      /siteroot/lib/phpunit/classes/advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit "filter_activitynames_filter_testcase" filter/activitynames/tests/filter_test.php
      

       

      1)
      filter_glossary_filter_testcase::test_brackets
      Failed asserting that 2 matches expected 3.
       
      /siteroot/filter/glossary/tests/filter_test.php:230
      /siteroot/lib/phpunit/classes/advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit "filter_glossary_filter_testcase" filter/glossary/tests/filter_test.php
      

       

      Commands to replicate:

      ./vendor/bin/phpunit --testsuite filter_activitynames_testsuite,filter_glossary_testsuite
      

      ./vendor/bin/phpunit --testsuite core_grades_testsuite,filter_activitynames_testsuite
      

       

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                mikhailgolenkov Mikhail Golenkov
                Reporter:
                mikhailgolenkov Mikhail Golenkov
                Peer reviewer:
                Dmitrii Metelkin
                Integrator:
                Andrew Nicols
                Participants:
                Component watchers:
                Jake Dallimore, Jun Pataleta, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours
                  3h