[MDL-67470] Boost: Wrong colour around some cogs if $card-bg is set - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.8
Fix Version/s: 3.7.4, 3.8.1
Component/s: Themes
Labels:
- ci
- triaged

Testing Instructions:
Hide

As admin navigate to Site administration > Appearance > Themes > Boost

Open the advanced settings tab and add this to field "Raw initial SCSS"

$card-bg: red;

Switch into any active course with an administrator account

Go into the Participants section

Verify there is no red box behind the settings menu cog
Show
As admin navigate to Site administration > Appearance > Themes > Boost Open the advanced settings tab and add this to field "Raw initial SCSS" $card-bg: red; Switch into any active course with an administrator account Go into the Participants section Verify there is no red box behind the settings menu cog
Affected Branches:
MOODLE_38_STABLE
Fixed Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE
Pull from Repository:
git://github.com/junpataleta/moodle.git
Pull 3.7 Branch:
~~MDL-67470~~-37
Pull 3.7 Diff URL:
https://github.com/junpataleta/moodle/compare/6e8eb9c0b2...MDL-67470-37
Pull 3.8 Branch:
~~MDL-67470~~-38
Pull 3.8 Diff URL:
https://github.com/junpataleta/moodle/compare/f2db42f921...MDL-67470-38
Pull Master Branch:
~~MDL-67470~~-master
Pull Master Diff URL:
https://github.com/junpataleta/moodle/compare/7850f76a93...MDL-67470-master

Description

System:

Debian 10 with Moodle 3.8+ (Build: 20191122)

Steps to recreate:

Switch to the boost theme
Add this:
$card-bg: red;
to "Raw initial SCSS" in the boost settings

Switch into any active course with an administrator account
Go into the Participants section
Now theres a red box under the cog icon.

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

Screenshot_2019-12-06 AI1004 WS 1920 Participants(1).png
27 kB
06/Dec/19 5:20 PM

Issue Links

mentioned on

Commit - MDL-67470 theme_boost: settings_menu_proxy correct background

Commit - Merge branch 'MDL-67470-38' of git://github.com/junpataleta/moodle into MOODLE_38_STABLE

Activity

People

Assignee:: Bas Brands

Reporter:: Carsten Schöffel

Peer reviewer:: Luca Bösch

Integrator:: Jun Pataleta

Tester:: Jun Pataleta

Participants:: Bas Brands, Carsten Schöffel, CiBoT, Eloy Lafuente (stronk7), Gitlab MoodleCloud, Janelle Barcega, Jun Pataleta, Luca Bösch

Component watchers:: Bas Brands

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 06/Dec/19 5:20 PM

Updated:: 14/Jan/20 10:41 AM

Resolved:: 03/Jan/20 11:55 AM

Fix Release Date:: 13/Jan/20

Time Tracking

Estimated:

Not Specified

Remaining:

0m

Logged:

1h 11m