[MDL-67471] mark_notification_read fails if messaging disabled - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.7.4, 3.8.1, 3.9
Fix Version/s: 3.7.5, 3.8.2
Component/s: Messages
Labels:
- ci
- release_notes

Affected Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE
Pull from Repository:
https://github.com/t-schroeder/moodle
Pull Master Branch:
~~MDL-67471~~_master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...t-schroeder:MDL-67471_master
Testing Instructions:
Hide

As admin disable messaging via Site administration -> Messaging -> Messaging settings -> Enable messaging system: No

Create a popover notification.

As admin create a course with a teacher and a student in it.

As teacher create an assignment in that course.

As student submit a file to that assignment.
=> As the student you should now see a 1 next to the bell icon at the top.

As student click on the bell icon.

Click on the link "View full notification" next to the unread notification.

This shouldn't give an error but without the fix you get the error shown in the screenshot.
Show
As admin disable messaging via Site administration -> Messaging -> Messaging settings -> Enable messaging system: No Create a popover notification. As admin create a course with a teacher and a student in it. As teacher create an assignment in that course. As student submit a file to that assignment. => As the student you should now see a 1 next to the bell icon at the top. As student click on the bell icon. Click on the link "View full notification" next to the unread notification. This shouldn't give an error but without the fix you get the error shown in the screenshot.

Description

When messaging is disabled for the site and you have unread popover notifications click on the "View full notification" link of one of those unread notifications. The page will load, but then the AJAX request to mark that notification as read fails and you get an error dialog box.

This makes no sense as notifications and messages are separate with each having its own DB table. The function "mark_notification_read" only sets the column "timeread" in the notifications table. However, it contains this check:

https://github.com/moodle/moodle/blob/fcc93935bea314457591b5b0e4ee7a227fbfea95/message/externallib.php#L3616-L3619

That check should just be removed as messaging doesn't use the notification table (anymore).

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

image-2020-02-19-09-30-19-505.png
82 kB
19/Feb/20 9:30 AM
view-full-notification-messaging-disabled-error-en.png
166 kB
06/Dec/19 6:21 PM

Issue Links

Discovered while testing

MDL-57755 Notifications automatically marked as read when messaging deactivated

Closed

is duplicated by

MDL-67918 Error when clicking unread notification with messaging disabled

Closed

Activity

People

Assignee:: Tim Schroeder

Reporter:: Tim Schroeder

Peer reviewer:: Neill Magill

Integrator:: Eloy Lafuente (stronk7)

Tester:: Janelle Barcega

Participants:: CiBoT, Eloy Lafuente (stronk7), Janelle Barcega, Neill Magill, Tim Schroeder

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 1 Vote for this issue

Watchers:: 8 Start watching this issue

Dates

Created:: 06/Dec/19 6:18 PM

Updated:: 04/Mar/20 6:31 PM

Resolved:: 21/Feb/20 11:40 AM

Fix Release Date:: 9/Mar/20

Time Tracking

Estimated:

Remaining:

Logged:

1h 15m