Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67472

Boost: Can not set Drawer Background with $drawer-bg scss variable

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.7.4, 3.8, 3.9
    • Fix Version/s: 3.7.5, 3.8.2
    • Component/s: Themes
    • Labels:

      Description

      Theres a SCSS variable called

      $drawer-bg
      

      which does essentially nothing in my eyes, as the drawer bg stays the same if it is set in "Raw initial scss". It is located in boost/scss/drawer.scss. If it should set the drawer background then the code in boost/scss/drawer.scss should be changed accordingly.

       

      For example from:

       

       

      /* Use a variable for the drawer background colors. */
      $drawer-bg: $gray-lighter !default;
       
      [data-region="drawer"] {
          position: fixed;
          padding: $drawer-padding-x $drawer-padding-y;
          width: $drawer-width;
          top: $fixed-header-y;
          height: calc(100% - #{$navbar-height});
          overflow-y: auto;
          -webkit-overflow-scrolling: touch;
          z-index: $zindex-dropdown - 1;
          background-color: darken($body-bg, 5%);
          -webkit-transition: right 0.5s ease, left 0.5s ease;
          -moz-transition: right 0.5s ease, left 0.5s ease;
          transition: right 0.5s ease, left 0.5s ease;
      }
      

       

      to

       

      /* Use a variable for the drawer background colors. */
      $drawer-bg: darken($body-bg, 5%) !default;
      //XOR
      $drawer-bg: darken($gray-lighter, 5%) !default;
       
      [data-region="drawer"] {
          position: fixed;
          padding: $drawer-padding-x $drawer-padding-y;
          width: $drawer-width;
          top: $fixed-header-y;
          height: calc(100% - #{$navbar-height});
          overflow-y: auto;
          -webkit-overflow-scrolling: touch;
          z-index: $zindex-dropdown - 1;
          background-color: $drawer-bg;
          -webkit-transition: right 0.5s ease, left 0.5s ease;
          -moz-transition: right 0.5s ease, left 0.5s ease;
          transition: right 0.5s ease, left 0.5s ease;
      }
      

       

       

       

        Attachments

          Activity

            People

            Assignee:
            basbrands Bas Brands
            Reporter:
            CarstenS Carsten Schöffel
            Peer reviewer:
            Luca Bösch
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Gladys Basiana
            Participants:
            Component watchers:
            Bas Brands
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              9/Mar/20

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 35 minutes
                35m