Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67491

Messaging: `badge-primary` missing from `contact-request-count` pill

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      With a Moodle instance setup;

      • Change primary theme color (brandcolor) to something dark;
      • Make a contact request from user B to user A. Make sure they're both enrolled in at least one same course together to assure they see each other.
      • As user A, open the right 'messages' popover and acknowledge that:
        • The little box right of the "Contacts" icon has a clear text on dark background
        • When clicking on the "Contacts" link, the icon right of "Requests" has the same.
      Show
      With a Moodle instance setup; Change primary theme color (brandcolor) to something dark; Make a contact request from user B to user A. Make sure they're both enrolled in at least one same course together to assure they see each other. As user A, open the right 'messages' popover and acknowledge that: The little box right of the "Contacts" icon has a clear text on dark background When clicking on the "Contacts" link, the icon right of "Requests" has the same.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Pull 3.7 Branch:
    • Pull 3.8 Branch:
    • Pull Master Branch:
      MDL-67491-master

      Description

      In the Message popover, when a request for contacts is sent, the tiny badge gets the theme's primary color as background, but no change for the text color; which can make readability hard.

        Attachments

          Activity

            People

            Assignee:
            odyx Didier Raboud
            Reporter:
            odyx Didier Raboud
            Peer reviewer:
            Luca Bösch
            Integrator:
            Jun Pataleta
            Tester:
            Jun Pataleta
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/Jan/20

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 46 minutes
                46m