[MDL-67511] Toast wrapper can interfere with Forum grading buttons - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: 3.8.1
Fix Version/s: 3.8.2
Component/s: Forum
Labels:
- ci
- release_notes
- triaged

Testing Instructions:
Hide

Login as an editing teacher or administrator

Create a Forum with "Whole forum grading" enabled in any course

Ensure that some users are enrolled in the course

Make the window extremely narrow (think the width of a phone)

View the forum

Press the "Grade users" button

Try to interact with the buttons at the top of the page (Save/Close/etc)

Confirm that you are able to use all of those features

Open Developer Tools (F12 key)

Open the Javascript console

Run the following code:

require(['core/toast'], function(T) { T.add('Example'); T.add('Another'); });

Confirm that you see "Another" at the top, followed by "Example" underneath it

Confirm that there is a gap between the top of the page and the first message
Show
Login as an editing teacher or administrator Create a Forum with "Whole forum grading" enabled in any course Ensure that some users are enrolled in the course Make the window extremely narrow (think the width of a phone) View the forum Press the "Grade users" button Try to interact with the buttons at the top of the page (Save/Close/etc) Confirm that you are able to use all of those features Open Developer Tools (F12 key) Open the Javascript console Run the following code: require(['core/toast'], function(T) { T.add('Example'); T.add('Another'); }); Confirm that you see "Another" at the top, followed by "Example" underneath it Confirm that there is a gap between the top of the page and the first message
Affected Branches:
MOODLE_38_STABLE
Fixed Branches:
MOODLE_38_STABLE
Epic Link:
Forum grader followup
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Master Branch:
~~MDL-67511~~-master
Pull Master Diff URL:
https://github.com/andrewnicols/moodle/compare/cb38ab1e39...MDL-67511-master

Description

If the forum grading interface is on a narrow enough screen buttons in the grading interface are not clickable as one would expect (Only the bottom of them is)

Attached is a screenshot showing the toasts area overlapping the buttons

The green area is were the toast area is preventing clicking.

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

buttons-overlapped-by-toast.png
31 kB
12/Dec/19 9:54 PM
MDL-67511_Step10.jpg
13 kB
05/Feb/20 2:32 PM
MDL-67511_Step7.avi
1.76 MB
05/Feb/20 2:33 PM

Activity

People

Assignee:: Andrew Lyons

Reporter:: Neill Magill

Peer reviewer:: Shamim Rezaie

Integrator:: Sara Arjona (@sarjona)

Tester:: Anna Carissa Sadia

Participants:: Andrew Lyons, Anna Carissa Sadia, CiBoT, Murray L, Neill Magill, Sara Arjona (@sarjona), Shamim Rezaie

Component watchers:: Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 12/Dec/19 9:53 PM

Updated:: 05/Mar/20 3:22 PM

Resolved:: 07/Feb/20 5:14 PM

Fix Release Date:: 9/Mar/20

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

2h 5m