Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67511

Toast wrapper can interfere with Forum grading buttons

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.8.1
    • Fix Version/s: 3.8.2
    • Component/s: Forum
    • Testing Instructions:
      Hide
      1. Login as an editing teacher or administrator
      2. Create a Forum with "Whole forum grading" enabled in any course
      3. Ensure that some users are enrolled in the course
      4. Make the window extremely narrow (think the width of a phone)
      5. View the forum
      6. Press the "Grade users" button
      7. Try to interact with the buttons at the top of the page (Save/Close/etc)
        1. Confirm that you are able to use all of those features
      8. Open Developer Tools (F12 key)
      9. Open the Javascript console
      10. Run the following code:

        require(['core/toast'], function(T) { T.add('Example'); T.add('Another'); });
        

        1. Confirm that you see "Another" at the top, followed by "Example" underneath it
        2. Confirm that there is a gap between the top of the page and the first message
      Show
      Login as an editing teacher or administrator Create a Forum with "Whole forum grading" enabled in any course Ensure that some users are enrolled in the course Make the window extremely narrow (think the width of a phone) View the forum Press the "Grade users" button Try to interact with the buttons at the top of the page (Save/Close/etc) Confirm that you are able to use all of those features Open Developer Tools (F12 key) Open the Javascript console Run the following code: require(['core/toast'], function(T) { T.add('Example'); T.add('Another'); }); Confirm that you see "Another" at the top, followed by "Example" underneath it Confirm that there is a gap between the top of the page and the first message
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull 3.8 Branch:
    • Pull Master Branch:
      MDL-67511-master

      Description

      If the forum grading interface is on a narrow enough screen buttons in the grading interface are not clickable as one would expect (Only the bottom of them is)

      Attached is a screenshot showing the toasts area overlapping the buttons

      The green area is were the toast area is preventing clicking.

        Attachments

          Activity

            People

            Assignee:
            dobedobedoh Andrew Nicols
            Reporter:
            nmagill Neill Magill
            Peer reviewer:
            Shamim Rezaie
            Integrator:
            Sara Arjona (@sarjona)
            Tester:
            Anna Carissa Sadia
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              9/Mar/20

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 5 minutes
                2h 5m