Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-6753

IMS enrolment in 1.7dev (2006092800) uses PHP5 syntax

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.7
    • Fix Version/s: 1.7
    • Component/s: Enrolments
    • Labels:
      None
    • Affected Branches:
      MOODLE_17_STABLE
    • Fixed Branches:
      MOODLE_17_STABLE

      Description

      IMS enrolment plugin is using some language constructs that are only available in PHP5, but 1.7 is supposed to work with 4.3.x or later.

      Namely it's using the 'public static' qualifier for '$imsroles' class variable and 'determine_defalt_rolemapping()' class function. It also breaks in PHP 4.3.10 withe the use of the scope resolution operator for 'enrolment_plugin_imsenterprise::$imsroles' in a couple of places, although it should work, according to PHP manuals.

      The errors prevent from displaying the enrolment configuration page.

      Saludos. Iñaki.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            dougiamas Martin Dougiamas added a comment -

            Dan, what are my chances of getting you to look at this?

            Show
            dougiamas Martin Dougiamas added a comment - Dan, what are my chances of getting you to look at this?
            Hide
            danstowell Dan Stowell added a comment -

            My apologies, I forgot to watch out for PHP4 compat. Now fixed, hopefully, although I haven't actually tested it on PHP4 - I've simply reverted to older syntax. Please test.

            Show
            danstowell Dan Stowell added a comment - My apologies, I forgot to watch out for PHP4 compat. Now fixed, hopefully, although I haven't actually tested it on PHP4 - I've simply reverted to older syntax. Please test.
            Hide
            iarenaza Iñaki Arenaza added a comment -

            Not it parses without trouble and you can get both the general enrolment configuration page and the IMS Enterprise configuration page. I assume the rest of the IMS functionality still works as expected, as I don't use IMS at all.

            Saludos. Iñaki.

            Show
            iarenaza Iñaki Arenaza added a comment - Not it parses without trouble and you can get both the general enrolment configuration page and the IMS Enterprise configuration page. I assume the rest of the IMS functionality still works as expected, as I don't use IMS at all. Saludos. Iñaki.
            Hide
            iarenaza Iñaki Arenaza added a comment -

            Ups! I meant now it parses without trouble

            Saludos. Iñaki.

            Show
            iarenaza Iñaki Arenaza added a comment - Ups! I meant now it parses without trouble Saludos. Iñaki.
            Hide
            mblake Michael Blake added a comment -

            This has been passed by Inaki.

            Show
            mblake Michael Blake added a comment - This has been passed by Inaki.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  7/Nov/06