Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67544

Collection of small ARIA bugs

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Setup

      1. Using Chrome, install the 'Axe' tool from https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd
      2. Install a new default site from scratch, without any previous customization or configuration.
      3. Create a forum in a course, and enable Whole forum grading on it

      NOTES

      There are some consistent failures to be aware of. These will be fixed in a separate issue and do not consitute a failure here. There are:

      1. "Main landmark must not be contained in another landmark"
      2. "All page content must be contained by landmarks"
      3. "Elements must have sufficient color contrast"
      4. "Heading levels should only increase by one"

      These are a bit of a pain to solve and will not be addressed by this issue.

      Test

      1. Navigate tot he forum
      2. Open your Developer tools and choose the "axe" tab (You may need to click it's logo in the toolbar beside the URL the first time)
      3. Click "Analyze"
        1. Confirm that the only issues shown were the ones noted above
      4. Click on the "Add a new discussion topic" button
      5. In "Axe" click "Run again"
        1. Confirm that the only issues shown were the ones noted above
      6. Enter a subject and message and "Post to forum"
        1. Analyze in Axe and confirm that the only issues shown were the ones noted above
      7. Open the "..." menu for the post you just created
        1. Analyze in Axe and confirm that the only issues shown were the ones noted above
      8. Pin, Lock, and Star the discussion
        1. Analyze in Axe and confirm that the only issues shown were the ones noted above
      9. Unpin, Unlock, and Unstar the discussion
      10. View the discussion
      11. Post two replies to it
      12. Post a reply to the first reply
      13. Refresh the page
        1. Analyze in Axe and confirm that the only issues shown were the ones noted above
      14. Open the "..." menu
        1. Analyze in Axe and confirm that the only issues shown were the ones noted above
      15. Switch display mode to "Display replies flat, with oldest first"
        1. Analyze in Axe and confirm that the only issues shown were the ones noted above
      16. Switch display mode to "Display replies flat, with newest first"
        1. Analyze in Axe and confirm that the only issues shown were the ones noted above
      17. Switch display mode to "Display replies in threaded form"
        1. Analyze in Axe and confirm that the only issues shown were the ones noted above
      18. Switch display mode to "Display replies in nested form"
        1. Analyze in Axe and confirm that the only issues shown were the ones noted above

      For 38 and master only

      1. Open User menu -> Preferences -> Forum preferences
      2. Set "Use experimental nested discussion view" to "Yes"
      3. Go back to the forum
      4. Switch display mode to "Display eplies in experimental nested form"
        1. Analyze in Axe and confirm that the only issues shown were the ones noted above
      5. Open the "..." menu
        1. Analyze in Axe and confirm that the only issues shown were the ones noted above
      6. Close the "..." menu
      7. Open the "Cog" menu at the top right (Settings)
        1. Analyze in Axe and confirm that the only issues shown were the ones noted above
      8. Go back to the list of discussions
      9. Click "Grade users"
        1. Analyze in Axe and confirm that the only issues shown were the ones noted above and...
          1. "IDs of active elements must be unique"
          2. "IDs used in ARIA and labels must be unique"
      Show
      Setup Using Chrome, install the 'Axe' tool from https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd Install a new default site from scratch, without any previous customization or configuration. Create a forum in a course, and enable Whole forum grading on it NOTES There are some consistent failures to be aware of. These will be fixed in a separate issue and do not consitute a failure here. There are: " Main landmark must not be contained in another landmark " " All page content must be contained by landmarks " " Elements must have sufficient color contrast " " Heading levels should only increase by one " These are a bit of a pain to solve and will not be addressed by this issue. Test Navigate tot he forum Open your Developer tools and choose the "axe" tab (You may need to click it's logo in the toolbar beside the URL the first time) Click "Analyze" Confirm that the only issues shown were the ones noted above Click on the "Add a new discussion topic" button In "Axe" click "Run again" Confirm that the only issues shown were the ones noted above Enter a subject and message and "Post to forum" Analyze in Axe and confirm that the only issues shown were the ones noted above Open the "..." menu for the post you just created Analyze in Axe and confirm that the only issues shown were the ones noted above Pin, Lock, and Star the discussion Analyze in Axe and confirm that the only issues shown were the ones noted above Unpin, Unlock, and Unstar the discussion View the discussion Post two replies to it Post a reply to the first reply Refresh the page Analyze in Axe and confirm that the only issues shown were the ones noted above Open the "..." menu Analyze in Axe and confirm that the only issues shown were the ones noted above Switch display mode to " Display replies flat, with oldest first " Analyze in Axe and confirm that the only issues shown were the ones noted above Switch display mode to " Display replies flat, with newest first " Analyze in Axe and confirm that the only issues shown were the ones noted above Switch display mode to " Display replies in threaded form " Analyze in Axe and confirm that the only issues shown were the ones noted above Switch display mode to " Display replies in nested form " Analyze in Axe and confirm that the only issues shown were the ones noted above For 38 and master only Open User menu -> Preferences -> Forum preferences Set " Use experimental nested discussion view " to "Yes" Go back to the forum Switch display mode to " Display eplies in experimental nested form " Analyze in Axe and confirm that the only issues shown were the ones noted above Open the "..." menu Analyze in Axe and confirm that the only issues shown were the ones noted above Close the "..." menu Open the "Cog" menu at the top right (Settings) Analyze in Axe and confirm that the only issues shown were the ones noted above Go back to the list of discussions Click "Grade users" Analyze in Axe and confirm that the only issues shown were the ones noted above and... "IDs of active elements must be unique" "IDs used in ARIA and labels must be unique"
    • Affected Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Pull 3.7 Branch:
    • Pull 3.8 Branch:
    • Pull Master Branch:
      MDL-67544-master

      Description

      This is just a small collection of minor ARIA bugs I came across today in the new forum grader.

      These were predominantly discovered using the Axe chrome plugin.

        Attachments

        1. 37-fail-1.png
          37-fail-1.png
          429 kB
        2. 37-fail-2.png
          37-fail-2.png
          191 kB
        3. MDL-67544.jpg
          MDL-67544.jpg
          80 kB
        4. MDL-67544 (2).jpg
          MDL-67544 (2).jpg
          51 kB
        5. MDL-67544 (3).jpg
          MDL-67544 (3).jpg
          42 kB
        6. MDL-67544 (4).jpg
          MDL-67544 (4).jpg
          40 kB
        7. MDL-67544 (5).jpg
          MDL-67544 (5).jpg
          56 kB
        8. MDL-67544 (6).jpg
          MDL-67544 (6).jpg
          60 kB
        9. MDL-67637_IDsAria.jpg
          MDL-67637_IDsAria.jpg
          42 kB

          Activity

            People

            Assignee:
            dobedobedoh Andrew Nicols
            Reporter:
            dobedobedoh Andrew Nicols
            Peer reviewer:
            Jun Pataleta
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Anna Carissa Sadia
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/Jan/20

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 2 hours, 30 minutes
                1d 2h 30m