Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67547

Render HTML in PDF dataformat export

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Test forum export containing an image

      1. Login as admin
      2. Create a course
      3. Add a Forum activity
      4. Press Add a new discussion topic
        • Subject: Cat
        • Message: Press Insert or add image and upload Cat.jpg
      5. Press Post to forum
      6. Select Export from the Actions menu
      7. Select Portable document format (PDF) in the Format dropdown
      8. Press Export
      9. Confirm the attached image is embedded within your PDF

      Manually test all writers with HTML content

      1. Login as admin
      2. Create a course
      3. Add a label
      4. Press Insert or add an image in the Atto toolbar
      5. Upload Cat.jpg
      6. Press Save and return to course
      7. On the course page, right click on the image and press Copy image location (in Firefox)
      8. Place dataformat_download.php in your wwwroot
      9. Replace the image URL on line 17 with the image you copied the location of previously
      10. Open "<YOURMOODLE>/dataformat_download.php" in a browser
      11. Click on each export format in turn:
        • csv, excel, html, ods, json should return content as before this change
        • pdf should render the HTML and display the image properly
      Show
      Test forum export containing an image Login as admin Create a course Add a Forum activity Press Add a new discussion topic Subject: Cat Message: Press Insert or add image and upload Cat.jpg Press Post to forum Select Export from the Actions menu Select Portable document format (PDF) in the Format dropdown Press Export Confirm the attached image is embedded within your PDF Manually test all writers with HTML content Login as admin Create a course Add a label Press Insert or add an image in the Atto toolbar Upload Cat.jpg Press Save and return to course On the course page, right click on the image and press Copy image location (in Firefox) Place dataformat_download.php in your wwwroot Replace the image URL on line 17 with the image you copied the location of previously Open "<YOURMOODLE>/dataformat_download.php" in a browser Click on each export format in turn: csv, excel, html, ods, json should return content as before this change pdf should render the HTML and display the image properly
    • Affected Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull Master Branch:

      Description

      Seems like some discussion when this was originally implemented (MDL-65142) already took place regarding HTML rendering

        Attachments

        1. Cat.jpg
          Cat.jpg
          21 kB
        2. dataformat_download.php
          1.0 kB
        3. MDL-67547.png
          MDL-67547.png
          66 kB
        4. MDL-67547-1.png
          MDL-67547-1.png
          389 kB

          Issue Links

            Activity

              People

              Assignee:
              pholden Paul Holden
              Reporter:
              pholden Paul Holden
              Peer reviewer:
              Marina Glancy
              Integrator:
              Andrew Nicols
              Tester:
              Anna Carissa Sadia
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              1 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jun/20

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 19 minutes
                  1d 19m