Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67585

New API for extending the activity chooser and implementation of favouriting

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Testing the callback deprecation

      1. Create a few preconfigured tools (admin > plugins > manage tools) and set to show up in the activity chooser.
      2. In mod/lti/lib.php, find the method 'lti_get_course_content_items' and rename it (just add a few random letter into the name so it won't be found).
      3. Now, go to a course as either the admin or a teacher.
      4. Turn on editing mode.
      5. Verify you see a debugging message on the page, telling you about the deprecated get_shortcuts callback.
      6. Now open the activity chooser
      7. Verify you see the preconfigured tools in the list of activities
      8. Click one
      9. Verify you are taken to the tool configuration page, allowing you to create the module instance.

      Testing a single activity format for modules with subtypes

      1. Make sure you have preconfigured tools set up and visible in the activity chooser.
      2. Create a new course
      3. Edit settings, and select single activity format. Wait for page to reload, this is normal.
      4. Pick 'External tool' from the list of activities and save.
      5. Verify you're taken to a page with 'Add a resource' and 'Add an activity' select menus. This is a fallback page expected when modules have several subtypes in the chooser.
      6. Now, edit the course again, this time picking 'chat' for the target of the single activity format.
      7. Verify you're taken to the edit page for that activity.
      8. Now, make sure all your preconfigured tools are set to NOT display in the chooser.
      9. Create a new course
      10. Edit settings, setting single activity format.
      11. Now, select external tool and save
      12. Verify you are taken to the edit page for the external tool.
      Show
      Testing the callback deprecation Create a few preconfigured tools (admin > plugins > manage tools) and set to show up in the activity chooser. In mod/lti/lib.php, find the method 'lti_get_course_content_items' and rename it (just add a few random letter into the name so it won't be found). Now, go to a course as either the admin or a teacher. Turn on editing mode. Verify you see a debugging message on the page, telling you about the deprecated get_shortcuts callback. Now open the activity chooser Verify you see the preconfigured tools in the list of activities Click one Verify you are taken to the tool configuration page, allowing you to create the module instance. Testing a single activity format for modules with subtypes Make sure you have preconfigured tools set up and visible in the activity chooser. Create a new course Edit settings, and select single activity format. Wait for page to reload, this is normal. Pick 'External tool' from the list of activities and save. Verify you're taken to a page with 'Add a resource' and 'Add an activity' select menus. This is a fallback page expected when modules have several subtypes in the chooser. Now, edit the course again, this time picking 'chat' for the target of the single activity format. Verify you're taken to the edit page for that activity. Now, make sure all your preconfigured tools are set to NOT display in the chooser. Create a new course Edit settings, setting single activity format. Now, select external tool and save Verify you are taken to the edit page for the external tool.
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-67585-master-4
    • Story Points:
      3
    • Sprint:
      Activity Sprint 4, Activity Sprint 5, Activity Sprint 6, Activity Sprint 7

      Description

      Backend implementation of favouriting for the activity chooser.

      Add unit tests to prove that this is working as intended.

      Add favourites to webservice displaying the chooser
      Add webservice for adding a favourite.
      Add webservice for removing a favourite.

        Attachments

        1. Screenshot_1.png
          169 kB
          Janelle Barcega
        2. Screenshot_2.png
          94 kB
          Janelle Barcega

          Issue Links

            Activity

              People

              Assignee:
              jaked Jake Dallimore
              Reporter:
              abgreeve Adrian Greeve
              Peer reviewer:
              Mathew May
              Integrator:
              Jun Pataleta
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jun/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 weeks, 3 days, 6 hours
                  2w 3d 6h