Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67590

grunt ignorefiles on Windows platforms may lead to "broken" ignore paths

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.5.9, 3.6.7, 3.7.3, 3.8
    • Fix Version/s: None
    • Component/s: JavaScript
    • Labels:
      None
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE

      Description

      When doing grunt ignorefiles on Windows systems, this can lead to ignorefiles containing the following path (as an example):

      auth\saml2\extlib\saml2/

      Worse, this could also lead to stuff like

      auth\saml2\extlib\saml2\/

      To prevent this we changed

      var lib = path.join(dirname, node.toString());

      to

      var lib = path.posix.join(dirname, node.toString());

      I'm not sure if this is really a bug or if this would be massaged away by the linting processes.
      I just want to check because this is a hack I'd like to lose if it isn't necessary.

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            poggenpohlda Daniel Poggenpohl
            Participants:
            Component watchers:
            Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated: