Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67599

A good number of behat tests are using (now old) dates and failing

    XMLWordPrintable

    Details

      Description

      A nice "new year" cataclysm.

      On January 1st 2020 a good number of behat tests (goutte and chrome) have started to fail consistently (all branches).

      Goutte: https://ci.moodle.org/view/B%20-%20master/job/W.05.01%20-%20Behat%20-%20Goutte%20+%20Postgres%20+%20Classic/325/
      Chrome: https://ci.moodle.org/view/B%20-%20master/job/W.03.01%20-%20Behat%20-%20Chrome%20+%20Postgres/611/

      It seems that we have a good number of tests were January 1st 2020 was being used to configure overrides in activities and other bits. As far as not always (now) past dates are allowed... now those tests fail (all branches):

      ag 2020 -l | grep "\.feature" 
      admin/tool/uploaduser/tests/behat/upload_users.feature
      backup/util/ui/tests/behat/restore_moodle2_courses.feature
      mod/chat/tests/behat/chat_course_reset.feature
      mod/quiz/tests/behat/quiz_user_override.feature
      mod/assign/tests/behat/steps_blind_marking.feature
      mod/assign/tests/behat/assign_group_override.feature
      mod/assign/tests/behat/assign_course_reset.feature
      mod/assign/tests/behat/assign_user_override.feature
      mod/lesson/tests/behat/date_availability.feature
      mod/lesson/tests/behat/lesson_user_override.feature
      mod/lesson/tests/behat/lesson_group_override.feature
      

      This issue is about:

      1) ASAP, fix all the now borked tests so we can be back to green at all costs. And proceed with weeklies and minors next week. I'd suggest changing any 2020 and 2021 case to +10 and done - note that the expectations (weekday) surely also need to be fixed in a number of cases.

      2) Invent a way to change all those tests (2019, 2020, 2021, 2030, 2031...) to accept dynamic/relative dates, we cannot rely on future absolutes. This can be done in another issue, but it's a MUST (IMO).

      Ciao

        Attachments

          Activity

            People

            Assignee:
            jaked Jake Dallimore
            Reporter:
            stronk7 Eloy Lafuente (stronk7)
            Peer reviewer:
            Adrian Greeve
            Integrator:
            Adrian Greeve
            Tester:
            CiBoT
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/Jan/20

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 1 minute
                3h 1m