Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67602

calendar api / numerical validation improvements with leading zeros

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 3.9
    • Calendar, General
    • None
    • MOODLE_39_STABLE

      This has been created after applying an immediate fix @ MDL-67598

      Basically it's about how numerical (int, float...) parameters are handled by calendar API and, by extension, globally. More specifically when the numerical values have leading zeros.

      There are various approaches to solve / improve current situation, and they are NOT mutually exclusive.

      A) Modify the calendar API internals to better support passed params with leading zeros. Cast within the functions body.

      B) Modify the calendar API applying for more type-hinted params that will perform the correct implicit casting.

      C) Modify clean_param() / validate_param() to globally support the leading zeros case in numerical types. There is a proposed patch applying for this from dobedobedoh .

      Ciao

            Unassigned Unassigned
            stronk7 Eloy Lafuente (stronk7)
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.