Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67610

Forum read tracking includes private replies

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE, MOODLE_311_STABLE
    • Pull 3.10 Branch:
      MDL-67610-310-2
    • Pull 3.11 Branch:
      MDL-67610-311-2
    • Pull Master Branch:
      MDL-67610-master-2
    • Testing Instructions:
      Hide
      Setup
      1. Course
      2. Students (s1, s2), editing teacher (t1), non-editing teacher (t2) with Forum tracking enabled.
      3. Groups g1 and g2. With s1 in g1 and s2 in g2.
        • Preferences > Forum preferences. Enable "Forum tracking"
      4. Forums f1 and f2.
        • Set f1's "Group mode" to Separate groups
      5. As a teacher or admin, go to f2
      6. Click on the cog menu and press "Permissions"
      7. Search for the "mod/forum:readprivatereplies" capability and remove the "Non-editing teacher" from the list of roles under the "Roles with permission" column.
      Test
      1. Log in as a student s1.
      2. Create a discussion in a forum 1.
      3. Create another discussion in forum 2
      4. Log in as t1
      5. Confirm that you see:
        • 1 unread post for f1 (since editing teachers have the "moodle/site:accessallgroups" capability)
        • 1 unread post for f2.
      6. Create a normal reply to s1's post in f1.
      7. Create a private reply to s1's post f1.
      8. Create a normal reply to s1's post in f2.
      9. Create a private reply to s1's post f2.
      10. Log in as s1.
      11. Go to the course homepage.
      12. Confirm that you see 2 unread posts for both f1 and f2 (one for t1's normal reply, and the other one for the private reply)
      13. Log in as s2.
      14. Go to the course homepage.
      15. Confirm that there are no unread posts for f1 (since s2 does not belong to s1's group)
      16. Confirm that you see 2 unread posts for f2 (one for s1's discussion post and the other one for t1's normal reply)
      17. Log in as t2.
      18. Go to the course homepage.
      19. Confirm that you see:
        • 3 posts for f1 (since even though t2's not in a group and has no "moodle/site:accessallgroups" capability, it has the read private replies capability)
        • 2 unread posts for f2 (one for s1's discussion post and the other one for t1's normal reply)
      20. Open
      Show
      Setup Course Students (s1, s2), editing teacher (t1), non-editing teacher (t2) with Forum tracking enabled. Groups g1 and g2. With s1 in g1 and s2 in g2. Preferences > Forum preferences. Enable " Forum tracking " Forums f1 and f2. Set f1's " Group mode " to Separate groups As a teacher or admin, go to f2 Click on the cog menu and press "Permissions" Search for the " mod/forum:readprivatereplies " capability and remove the "Non-editing teacher" from the list of roles under the " Roles with permission " column. Test Log in as a student s1. Create a discussion in a forum 1. Create another discussion in forum 2 Log in as t1 Confirm that you see: 1 unread post for f1 (since editing teachers have the " moodle/site:accessallgroups " capability) 1 unread post for f2. Create a normal reply to s1's post in f1. Create a private reply to s1's post f1. Create a normal reply to s1's post in f2. Create a private reply to s1's post f2. Log in as s1. Go to the course homepage. Confirm that you see 2 unread posts for both f1 and f2 (one for t1's normal reply, and the other one for the private reply) Log in as s2. Go to the course homepage. Confirm that there are no unread posts for f1 (since s2 does not belong to s1's group) Confirm that you see 2 unread posts for f2 (one for s1's discussion post and the other one for t1's normal reply) Log in as t2. Go to the course homepage. Confirm that you see: 3 posts for f1 (since even though t2's not in a group and has no " moodle/site:accessallgroups " capability, it has the read private replies capability) 2 unread posts for f2 (one for s1's discussion post and the other one for t1's normal reply) Open
    • Story Points:
      0
    • Sprint:
      HQ Team International Sprint 6, HQ Team International Sprint 7, HQ Team International Sprint 8

      Description

      If a forum has any private replies between a teacher and a student the private reply from the teacher is included in the unread posts the other students in the course will see, when forum post tracking is enabled in any of the students preferences.

      This is confusing as only the student who the private reply is for will see it but the other students will not be able to see it but the unread posts total will include it.

        Attachments

          Activity

            People

            Assignee:
            jpataleta Jun Pataleta
            Reporter:
            bmatthias Barry Matthias
            Peer reviewer:
            Dongsheng Cai Dongsheng Cai
            Integrator:
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Tester:
            Gladys Basiana Gladys Basiana
            Participants:
            Component watchers:
            Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            12 Vote for this issue
            Watchers:
            21 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/Sep/21

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 days, 1 hour, 21 minutes
                2d 1h 21m