Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67623

Course overview (my courses block) pagination is broken beyond the second page

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      (difficulty: easy, requires admin access, 25 test courses created)
      No pagination controls should be displayed when user not enrolled in any courses

      1. Log in as Admin
      2. Create a new Student user
      3. Log out
      4. Log in as Student user
      5. TEST: You should see 'No courses' in the Course overview block
      6. TEST: You should not see 'Show' at the bottom of the Course overview block
      7. TEST: You should not see the next page pagination icon (>) or the previous page pagination icon (<)

      Pagination should be hidden when there is only one option

      1. Log in as Admin
      2. Create a new Student user
      3. Enrol Student user in 12 courses exactly
      4. Log out
      5. Log in as Student user
      6. TEST: You should only see 12 courses in the Course overview block
      7. TEST: You should not see 'Show' at the bottom of the Course overview block
      8. TEST: You should not see the next page pagination icon (>) or the previous page pagination icon (<)
      9. Log out

      Pagination should work for pages past the second

      1. Log in as Admin
      2. Create a new Student user
      3. Enrol Student user in 25 courses
      4. Log out
      5. Log in as Student user
      6. TEST: The pagination dropdown beside Show option should have defaulted to 12 (Note: If you used an existing Student, this may not work, depending on if the user has selected a pagination option for the Course overview block previously, in which case, their previous saved preference will be used.)
      7. TEST: You should see 12 courses in the Course overview block
      8. TEST: You should not be able to select the back pagination option in the Course overview block (the < icon at the bottom right)
      9. Use next page pagination icon (>) to navigate to the second page of courses.
      10. TEST: You should only see 12 courses in the Course overview block
      11. TEST: The next page pagination icon (>) and previous page pagination icon (<) should be selectable
      12. Use next page pagination icon (>) to navigate to the third page of courses.
      13. TEST: You should now only see 1 course in the Course overview block
      14. TEST: The next page pagination icon (>) should not be selectable
      15. TEST: You should be able to select the previous page icon (<) twice to return to first page of courses
      16. Log out

      Pagination should work when total courses is the same as one of the pagination options

      1. Log in as Admin
      2. Create a Student user
      3. Enrol Student user in 24 courses exactly
      4. Log out
      5. Log in as Student user
      6. Click the dropdown beside Show to reveal the pagination options
      7. TEST: You should only see 12 and All options in the dropdown
      8. In the Course overview block of the Dashboard set the Show option to 12
      9. Use next page pagination icon (>) to navigate to the next page of courses.
      10. TEST: You should only see 12 courses in the Course overview block
      11. TEST: The next page pagination icon (>) should not be selectable
      12. In the Course overview block of the Dashboard set the Show option to All
      13. TEST: You should see all 24 courses
      14. Log out
      Show
      (difficulty: easy, requires admin access, 25 test courses created) No pagination controls should be displayed when user not enrolled in any courses Log in as Admin Create a new Student user Log out Log in as Student user TEST: You should see 'No courses' in the Course overview block TEST: You should not see 'Show' at the bottom of the Course overview block TEST: You should not see the next page pagination icon ( > ) or the previous page pagination icon ( < ) Pagination should be hidden when there is only one option Log in as Admin Create a new Student user Enrol Student user in 12 courses exactly Log out Log in as Student user TEST: You should only see 12 courses in the Course overview block TEST: You should not see 'Show' at the bottom of the Course overview block TEST: You should not see the next page pagination icon ( > ) or the previous page pagination icon ( < ) Log out Pagination should work for pages past the second Log in as Admin Create a new Student user Enrol Student user in 25 courses Log out Log in as Student user TEST: The pagination dropdown beside Show option should have defaulted to 12 (Note: If you used an existing Student, this may not work, depending on if the user has selected a pagination option for the Course overview block previously, in which case, their previous saved preference will be used.) TEST: You should see 12 courses in the Course overview block TEST: You should not be able to select the back pagination option in the Course overview block (the < icon at the bottom right) Use next page pagination icon ( > ) to navigate to the second page of courses. TEST: You should only see 12 courses in the Course overview block TEST: The next page pagination icon ( > ) and previous page pagination icon ( < ) should be selectable Use next page pagination icon ( > ) to navigate to the third page of courses. TEST: You should now only see 1 course in the Course overview block TEST: The next page pagination icon ( > ) should not be selectable TEST: You should be able to select the previous page icon ( < ) twice to return to first page of courses Log out Pagination should work when total courses is the same as one of the pagination options Log in as Admin Create a Student user Enrol Student user in 24 courses exactly Log out Log in as Student user Click the dropdown beside Show to reveal the pagination options TEST: You should only see 12 and All options in the dropdown In the Course overview block of the Dashboard set the Show option to 12 Use next page pagination icon ( > ) to navigate to the next page of courses. TEST: You should only see 12 courses in the Course overview block TEST: The next page pagination icon ( > ) should not be selectable In the Course overview block of the Dashboard set the Show option to All TEST: You should see all 24 courses Log out
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE, MOODLE_39_STABLE
    • Pull from Repository:
    • Pull 3.9 Branch:
      MDL-67623-39_blocks_myoverview_pagination_regression
    • Pull 3.10 Branch:
      MDL-67623-310_blocks_myoverview_pagination_regression
    • Pull 3.11 Branch:
      MDL-67623-311_blocks_myoverview_pagination_regression
    • Pull Master Branch:
      MDL-67623-40_blocks_myoverview_pagination_regression

      Description

      you need to be enrolled to more than 24 courses 

       - go to dashboard 

       -  in course overview "Show" filter click 12 

      now you can see that you can't move to the third page 

        Attachments

        1. manually_checking_failures.png
          manually_checking_failures.png
          353 kB
        2. MDL-67623.jpg
          MDL-67623.jpg
          61 kB
        3. MDL-67623 (2).jpg
          MDL-67623 (2).jpg
          49 kB
        4. MDL-67623 (3).jpg
          MDL-67623 (3).jpg
          39 kB
        5. MDL-70397.jpg
          MDL-70397.jpg
          70 kB
        6. Screenshot from 2020-01-06 22-41-35.png
          Screenshot from 2020-01-06 22-41-35.png
          421 kB
        7. Screenshot from 2020-01-06 22-41-46.png
          Screenshot from 2020-01-06 22-41-46.png
          426 kB

          Issue Links

            Activity

              People

              Assignee:
              tom_d Tom Dickman
              Reporter:
              chenlevy Chen Levy
              Peer reviewer:
              Andrew Madden Andrew Madden
              Integrator:
              Jake Dallimore Jake Dallimore
              Tester:
              Anna Carissa Sadia Anna Carissa Sadia
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              9 Vote for this issue
              Watchers:
              20 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Jan/21

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 50 minutes
                  2h 50m