Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67626

In assignments submission and feedback text can't be expand/contract either IE or Safari

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-67626_master
    • Pull Master Diff URL:
    • Testing Instructions:
      Hide

      Note: Test the expand/collapse button appearance and functionality on all supported browsers. Accessibility testing on any browser should suffice.

      Preparations

      1. Log in as Admin
      2. Create a Course
      3. Enroll a Student in the Course
      4. Create an Assignment activity
        • For "Submission types" enable "Online text"

      Submission

      1. Login as a Student
      2. Go to Course > Assignment
      3. Add an "Online text" submission (make sure to add a longer content, e.g. >500 words) and "Save changes"
      4. In the Assignment page there should be a table row that shows a preview of the submitted "Online text" submission:
        • make sure there is toggleable +/- link that shows a preview of the full Online text submission
      5. Using JAWS or another screen reader navigate through the Assignment page.
      6. Attempt to navigate to the +/- link in the "Online text" table row:
        • make sure the +/- link is accessible with the screen reader and the reader properly describes (reads) its function

      Grading

      1. Login as Admin
      2. Go to the Course > Assignment
      3. Go to "View all submissions"
      4. Click on the "Grade" button that represents the Student's submission
      5. In the Grading page:
        • make sure there is toggleable +/- link that shows a preview or the full Online text submission
      6. Using JAWS or another screen reader navigate through the Grading page
      7. Attempt to navigate to the +/- link:
        • make sure the +/- link is accessible with the screen reader and the reader properly describes (reads) its function
      8. In the same Grading page:
        1. Add a grade
        2. Add a longer Feedback comment (make sure to add a longer content, e.g. >500 words)
        3. Save changes
      9. Login as the Student
      10. Go back to the Assignment page
      11. In the Assignment page there should be a table row that shows a preview of the feedback comments:
        • make sure there is toggleable +/- link that shows a preview or the full feedback comment

      Info:

      While focused on the +/- link and press "Enter" is not working, also not with the actual code base.

      Thanks and credits belongs to Mihail Geshoski

      Show
      Note: Test the expand/collapse button appearance and functionality on all supported browsers. Accessibility testing on any browser should suffice. Preparations Log in as Admin Create a Course Enroll a Student in the Course Create an Assignment activity For "Submission types" enable "Online text" Submission Login as a Student Go to Course > Assignment Add an "Online text" submission (make sure to add a longer content, e.g. >500 words) and "Save changes" In the Assignment page there should be a table row that shows a preview of the submitted "Online text" submission: make sure there is toggleable +/- link that shows a preview of the full Online text submission Using JAWS or another screen reader navigate through the Assignment page. Attempt to navigate to the +/- link in the "Online text" table row: make sure the +/- link is accessible with the screen reader and the reader properly describes (reads) its function Grading Login as Admin Go to the Course > Assignment Go to "View all submissions" Click on the "Grade" button that represents the Student's submission In the Grading page: make sure there is toggleable +/- link that shows a preview or the full Online text submission Using JAWS or another screen reader navigate through the Grading page Attempt to navigate to the +/- link: make sure the +/- link is accessible with the screen reader and the reader properly describes (reads) its function In the same Grading page: Add a grade Add a longer Feedback comment (make sure to add a longer content, e.g. >500 words) Save changes Login as the Student Go back to the Assignment page In the Assignment page there should be a table row that shows a preview of the feedback comments: make sure there is toggleable +/- link that shows a preview or the full feedback comment Info: While focused on the +/- link and press "Enter" is not working, also not with the actual code base. Thanks and credits belongs to Mihail Geshoski

      Description

      When using Internet Explorer 11 the submitted online text can't be expanded nor contracted in assignment view. It's really a legacy stuff as it uses the YUI library. But as I found it's a regression from some accessibility changes.

      The problem occurs e.g. with this version:

      This will help to resolve this issue:

      • add "#" to href of expandsummaryicon link
      • the CSS attribute display of expandsummaryicon must be set to inline-block

      Changing that will make it working again on IE11 and it will still work on Chrome and FF.

        Attachments

          Issue Links

          is a regression caused by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-61121 Assignment accessibility correct use of tables and toggleable +/- link

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-67633 Assignment feedback comments expand/contract icons don't work in IE 11

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              pead Adrian Perez
              Reporter:
              pead Adrian Perez
              Peer reviewer:
              Víctor Déniz Falcón Víctor Déniz Falcón
              Integrator:
              Jun Pataleta Jun Pataleta
              Tester:
              Anna Carissa Sadia Anna Carissa Sadia
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              1 Vote for this issue
              Watchers:
              10 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 5 hours, 30 minutes
                  1d 5h 30m