Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67626

In assignments submission and feedback text can't be expand/contract either IE or Safari

XMLWordPrintable

    • MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
    • MOODLE_37_STABLE, MOODLE_38_STABLE
    • MDL-67626_master
    • Hide

      Note: Test the expand/collapse button appearance and functionality on all supported browsers. Accessibility testing on any browser should suffice.

      Preparations

      1. Log in as Admin
      2. Create a Course
      3. Enroll a Student in the Course
      4. Create an Assignment activity
        • For "Submission types" enable "Online text"

      Submission

      1. Login as a Student
      2. Go to Course > Assignment
      3. Add an "Online text" submission (make sure to add a longer content, e.g. >500 words) and "Save changes"
      4. In the Assignment page there should be a table row that shows a preview of the submitted "Online text" submission:
        • make sure there is toggleable +/- link that shows a preview of the full Online text submission
      5. Using JAWS or another screen reader navigate through the Assignment page.
      6. Attempt to navigate to the +/- link in the "Online text" table row:
        • make sure the +/- link is accessible with the screen reader and the reader properly describes (reads) its function

      Grading

      1. Login as Admin
      2. Go to the Course > Assignment
      3. Go to "View all submissions"
      4. Click on the "Grade" button that represents the Student's submission
      5. In the Grading page:
        • make sure there is toggleable +/- link that shows a preview or the full Online text submission
      6. Using JAWS or another screen reader navigate through the Grading page
      7. Attempt to navigate to the +/- link:
        • make sure the +/- link is accessible with the screen reader and the reader properly describes (reads) its function
      8. In the same Grading page:
        1. Add a grade
        2. Add a longer Feedback comment (make sure to add a longer content, e.g. >500 words)
        3. Save changes
      9. Login as the Student
      10. Go back to the Assignment page
      11. In the Assignment page there should be a table row that shows a preview of the feedback comments:
        • make sure there is toggleable +/- link that shows a preview or the full feedback comment

      Info:

      While focused on the +/- link and press "Enter" is not working, also not with the actual code base.

      Thanks and credits belongs to Mihail Geshoski

      Show
      Note: Test the expand/collapse button appearance and functionality on all supported browsers. Accessibility testing on any browser should suffice. Preparations Log in as Admin Create a Course Enroll a Student in the Course Create an Assignment activity For "Submission types" enable "Online text" Submission Login as a Student Go to Course > Assignment Add an "Online text" submission (make sure to add a longer content, e.g. >500 words) and "Save changes" In the Assignment page there should be a table row that shows a preview of the submitted "Online text" submission: make sure there is toggleable +/- link that shows a preview of the full Online text submission Using JAWS or another screen reader navigate through the Assignment page. Attempt to navigate to the +/- link in the "Online text" table row: make sure the +/- link is accessible with the screen reader and the reader properly describes (reads) its function Grading Login as Admin Go to the Course > Assignment Go to "View all submissions" Click on the "Grade" button that represents the Student's submission In the Grading page: make sure there is toggleable +/- link that shows a preview or the full Online text submission Using JAWS or another screen reader navigate through the Grading page Attempt to navigate to the +/- link: make sure the +/- link is accessible with the screen reader and the reader properly describes (reads) its function In the same Grading page: Add a grade Add a longer Feedback comment (make sure to add a longer content, e.g. >500 words) Save changes Login as the Student Go back to the Assignment page In the Assignment page there should be a table row that shows a preview of the feedback comments: make sure there is toggleable +/- link that shows a preview or the full feedback comment Info: While focused on the +/- link and press "Enter" is not working, also not with the actual code base. Thanks and credits belongs to Mihail Geshoski

      When using Internet Explorer 11 the submitted online text can't be expanded nor contracted in assignment view. It's really a legacy stuff as it uses the YUI library. But as I found it's a regression from some accessibility changes.

      The problem occurs e.g. with this version:

      This will help to resolve this issue:

      • add "#" to href of expandsummaryicon link
      • the CSS attribute display of expandsummaryicon must be set to inline-block

      Changing that will make it working again on IE11 and it will still work on Chrome and FF.

        1. image-2020-01-06-22-52-13-816.png
          image-2020-01-06-22-52-13-816.png
          16 kB
        2. MDL-67626_Grading_Step7.mp4
          199 kB
        3. MDL-67626_Submission_Step6.mp4
          345 kB
        4. MDL-67626.jpg
          MDL-67626.jpg
          68 kB
        5. windows10ie11hrefempty.png
          windows10ie11hrefempty.png
          128 kB

            pead Adrian Perez
            pead Adrian Perez
            Victor Déniz Falcón Victor Déniz Falcón
            Jun Pataleta Jun Pataleta
            Anna Carissa Sadia Anna Carissa Sadia
            Votes:
            1 Vote for this issue
            Watchers:
            10 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 5 hours, 30 minutes
                1d 5h 30m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.