Loading...

XML

Word

Printable

Type: Improvement
Resolution: Fixed
Priority: Major
Fix Version/s: 4.4
Affects Version/s: 4.4
Component/s: Policy, Tasks
Labels:
- CatalystIT
- ci
- partner
- release_notes
- triaged

Affected Branches:
MOODLE_404_STABLE
Fixed Branches:
MOODLE_404_STABLE
Epic Link:
4.4 deprecations
Pull from Repository:
https://github.com/andrewnicols/moodle.git
Pull Main Branch:
~~MDL-67667~~-main
Pull Main Diff URL:
https://github.com/andrewnicols/moodle/compare/b621a7e4b3...MDL-67667-main?w=1
Testing Instructions:
1. Copy the attached mdl67667.php into your moodle root
2. Run it
  1. Confirm you were shown notices that the methods are deprecated

The is_blocking concept in the Task API has never really received much interest. The current and original implementation since 2.7 is buggy so it doesn't actually block correctly at all at scale (see ~~MDL-67597~~). It's also the root cause of scaling issues (mostly mitigated in ~~MDL-67486~~)

So proposing to deprecate this completely.

Forum to discuss deprecation:

https://moodle.org/mod/forum/discuss.php?d=395636

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

mdl67667.php
08/Apr/24 11:57 AM
0.3 kB
Andrew Lyons

has a non-specific relationship to

MDL-67597 Blocking cron tasks only effectively lock into the future not the past, ie race condition

Closed

MDL-67648 Cron task manager quality of service (version 3)

Closed

has been marked as being related by

MDL-80345 Hash collision guaranteed to break Cron with 'locktimeout' (only with PostgreSQL)

Closed

has to be done before

MDL-81509 Final deprecation of task_base::is_blocking and set_blocking

Closed

links to

Dev docs PR

Assignee:: Andrew Lyons

Reporter:: Brendan Heywood

Peer reviewer:: Matt Porritt

Integrator:: Jun Pataleta

Tester:: Jun Pataleta

Participants:: Andrew Lyons, Brendan Heywood, Carlos Escobedo, CiBoT, Eloy Lafuente (stronk7), Jun Pataleta, Matt Porritt, Neill Magill

Votes:: 3 Vote for this issue

Watchers:: 9 Start watching this issue

Created:: 11/Jan/20 1:24 PM

Updated:: 12/Sep/24 8:39 PM

Resolved:: 12/Apr/24 8:24 PM

Estimated:

Not Specified

Remaining:

Logged:

1h 31m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify