[MDL-67671] Backup → Step 2 → Show type options … something must be missing here - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.6.8, 3.7.4, 3.8.1
Fix Version/s: 3.8.5, 3.9.2
Component/s: Backup
Labels:
- ci
- patch
- triaged

Testing Instructions:
Hide

Setup

A course with different activities (such as forum, assignment, glossary...).

Testing scenario

In the course, initiate a backup.

Go to the second step (where there's the All / None (Show type options) handles) using the "Next" button.

Click on "Show type options".

Confirm each activity type present on the course have its plural name displayed above "All/None" links.
Show
Setup A course with different activities (such as forum, assignment, glossary...). Testing scenario In the course, initiate a backup. Go to the second step (where there's the All / None (Show type options) handles) using the "Next" button. Click on "Show type options". Confirm each activity type present on the course have its plural name displayed above "All/None" links.
Affected Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
Fixed Branches:
MOODLE_38_STABLE, MOODLE_39_STABLE
Pull from Repository:
https://github.com/marxjohnson/moodle.git
Pull 3.8 Branch:
~~MDL-67671~~_38_STABLE
Pull 3.8 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_38_STABLE...marxjohnson:MDL-67671_38_STABLE
Pull 3.9 Branch:
~~MDL-67671~~_39_STABLE
Pull 3.9 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_39_STABLE...marxjohnson:MDL-67671_39_STABLE
Pull Master Branch:
~~MDL-67671~~_master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...marxjohnson:MDL-67671_master

Description

The user interface when showing type options is lacking some elements and does not make sense.

To reproduce:

In a course, initiate Backup.
Go to the second step (where there's the All / None (Show type options) handles) using the "Next" button.
Click on "Show type options".

Additional remark: should All / None should be rewritten as mentioned in https://tracker.moodle.org/browse/MDL-66649.

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

image-2020-07-16-14-49-04-724.png
30 kB
16/Jul/20 2:49 PM
MDL-67671-should-be.png
150 kB
05/Jul/20 6:33 PM
Schema settings Show type options.png
222 kB
12/Jan/20 11:44 PM

Issue Links

is a regression caused by

MDL-65327 All module strings are fetched from the cache, regardless of whether they are needed

Closed

is duplicated by

MDL-68306 Restore: Missing icons/text when selecting "Show type options"

Closed

Activity

People

Assignee:: Mark Johnson

Reporter:: Luca Bösch

Peer reviewer:: Sam Marshall

Integrator:: Sara Arjona (@sarjona)

Tester:: Janelle Barcega

Participants:: Adrian Greeve, CiBoT, Dirk Meyer, Janelle Barcega, Luca Bösch, Mark Johnson, Sam Marshall, Sara Arjona (@sarjona)

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias

Votes:: 1 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 12/Jan/20 11:42 PM

Updated:: 30/Jul/20 6:42 AM

Resolved:: 17/Jul/20 3:53 AM

Fix Release Date:: 14/Sep/20

Time Tracking

Estimated:

0m

Remaining:

0m

Logged:

1h 11m