[MDL-67689] Improve theme designer mode performance - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.8.1, 3.9
Fix Version/s: 3.9
Component/s: Themes
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_39_STABLE
Pull from Repository:
git://github.com/bmbrands/moodle.git
Pull Master Branch:
~~MDL-67689~~-master
Pull Master Diff URL:
https://github.com/bmbrands/moodle/compare/f570a79071...MDL-67689-master
Testing Instructions:
Hide

In order to test this issue you must have access and edit rights to Moodle core files.

Log in as Admin

Navigate to Site Administration > Appearance > Themes > Theme Settings

Check the box "Theme designer mode"

Save Changes

Open Moodle file theme/boost/scss/preset/default.scss

Add "$card-bg: green;" to the first line of the file

Verify you see some of the page elements turned green

To test the performance improvement, record loading times with theme designer mode turned of on a Moodle install with this patch and without one.

The performance improvement should be about 50%.
Show
In order to test this issue you must have access and edit rights to Moodle core files. Log in as Admin Navigate to Site Administration > Appearance > Themes > Theme Settings Check the box "Theme designer mode" Save Changes Open Moodle file theme/boost/scss/preset/default.scss Add "$card-bg: green;" to the first line of the file Verify you see some of the page elements turned green To test the performance improvement, record loading times with theme designer mode turned of on a Moodle install with this patch and without one. The performance improvement should be about 50%.

Description

With theme designer mode turned on all scss is recompiled on each page load which can take a lot of time.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

image-2020-05-15-12-33-28-315.png
46 kB
15/May/20 12:33 PM

Issue Links

has a non-specific relationship to

MDL-69117 Improve theme designer mode - part 2

Closed

Activity

People

Assignee:: Bas Brands

Reporter:: Bas Brands

Peer reviewer:: Neill Magill

Integrator:: Andrew Lyons

Tester:: Janelle Barcega

Participants:: Andrew Lyons, Bas Brands, CiBoT, Janelle Barcega, Neill Magill

Component watchers:: Huong Nguyen, Bas Brands, Mathew May, Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 1 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 14/Jan/20 4:33 PM

Updated:: 23/Jun/20 4:49 PM

Resolved:: 15/May/20 5:47 PM

Fix Release Date:: 15/Jun/20

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

2h 31m