Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67689

Improve theme designer mode performance

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.8.1, 3.9
    • 3.9
    • Themes
    • MOODLE_38_STABLE, MOODLE_39_STABLE
    • MOODLE_39_STABLE
    • MDL-67689-master
    • Hide

      In order to test this issue you must have access and edit rights to Moodle core files.

      1. Log in as Admin
      2. Navigate to Site Administration > Appearance > Themes > Theme Settings
      3. Check the box "Theme designer mode"
      4. Save Changes
      5. Open Moodle file theme/boost/scss/preset/default.scss
      6. Add "$card-bg: green;" to the first line of the file
      7. Verify you see some of the page elements turned green

      To test the performance improvement, record loading times with theme designer mode turned of on a Moodle install with this patch and without one.

      The performance improvement should be about 50%.

      Show
      In order to test this issue you must have access and edit rights to Moodle core files. Log in as Admin Navigate to Site Administration > Appearance > Themes > Theme Settings Check the box "Theme designer mode" Save Changes Open Moodle file theme/boost/scss/preset/default.scss Add "$card-bg: green;" to the first line of the file Verify you see some of the page elements turned green To test the performance improvement, record loading times with theme designer mode turned of on a Moodle install with this patch and without one. The performance improvement should be about 50%.

    Description

      With theme designer mode turned on all scss is recompiled on each page load which can take a lot of time.

      Attachments

        Issue Links

          Activity

            People

              basbrands Bas Brands
              basbrands Bas Brands
              Neill Magill Neill Magill
              Andrew Lyons Andrew Lyons
              Janelle Barcega Janelle Barcega
              Huong Nguyen, Bas Brands, Mathew May
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                15/Jun/20

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 31 minutes
                  2h 31m