Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67700

Messages displaying in incorrect conversations when switching between conversations quickly

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Testing setup

      1. Create a course
      2. Create 5 users and assign them to the course this way: 1 teacher, 4 students
      3. Login as each student and do the following:
        1. Got into the course participants and click on the teacher
        2. On the teacher profile click on "Message" to start a conversation
        3. Send 4 messages to the teacher with texts (where X is different on every student):
          1. Student X message 1
          2. Student X message 2
          3. Student X message 3
          4. Student X message 4
      4. Login as the teacher and check that on the message drawer (on the top navbar) appear all conversations and you can read them.

      Test message mixing in boost

      1. Log as the teacher
      2. Click on the message drawer icon on the top navbar and then on the "see all" link.
      3. Open the "private" messages section and then open as fast as you can all four conversations (it is important to open each conversation before the previous one is loaded to queue connections)
      4. Once the last conversation is loaded wait for 20 seconds
        1. Check that nothing happens on the messaging. If the bug is still present message will get mixed up in the current conversation.
      5. Then click on another conversation and wait also 20 seconds
        1. Check that the messages from that conversation are correct and does not have and other messages from another conversations.
      6. Repeat step 5 for the 2 remaining conversation.

      Test message mixing in classic

      Repeat the same test in the classic theme.

      Show
      Testing setup Create a course Create 5 users and assign them to the course this way: 1 teacher, 4 students Login as each student and do the following: Got into the course participants and click on the teacher On the teacher profile click on "Message" to start a conversation Send 4 messages to the teacher with texts (where X is different on every student): Student X message 1 Student X message 2 Student X message 3 Student X message 4 Login as the teacher and check that on the message drawer (on the top navbar) appear all conversations and you can read them. Test message mixing in boost Log as the teacher Click on the message drawer icon on the top navbar and then on the "see all" link. Open the "private" messages section and then open as fast as you can all four conversations (it is important to open each conversation before the previous one is loaded to queue connections) Once the last conversation is loaded wait for 20 seconds Check that nothing happens on the messaging. If the bug is still present message will get mixed up in the current conversation. Then click on another conversation and wait also 20 seconds Check that the messages from that conversation are correct and does not have and other messages from another conversations. Repeat step 5 for the 2 remaining conversation. Test message mixing in classic Repeat the same test in the classic theme.
    • Affected Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull 3.8 Branch:
    • Pull Master Branch:
      MDL-67700-master
    • Sprint:
      Moodle 3.9 - Moppies Kanban

      Description

      We at praxis, encountered a bug where messages will get mixed up in different conversation, if you switch between senders too quickly.

       

      Reproduce:

      1. Created 5 accounts.
      2. All 5 accounts sent 5 messages to admin user.
      3. Admin user opens the message page from his menu.
      4. Select conversation with user 1.
      5. Before the text loads, select conversation with user 2.
      6. Now there is a mixup in messages.

       

      We have a customer, that is concerned it is a security risk.

       

      Video attached, showing the mix-up.

        Attachments

        1. Dashboard – Google Chrome 2020-01-15 11-34-02.mp4
          10.07 MB
        2. image-2020-05-22-12-02-54-816.png
          image-2020-05-22-12-02-54-816.png
          86 kB
        3. MDL-67700.jpg
          MDL-67700.jpg
          25 kB
        4. messaging_mixup_error.gif
          messaging_mixup_error.gif
          1.59 MB
        5. Missatges.png
          Missatges.png
          194 kB
        6. screenshot_021.png
          screenshot_021.png
          75 kB
        7. screenshot_022.png
          screenshot_022.png
          81 kB

          Issue Links

            Activity

              People

              Assignee:
              tusefomal Ferran Recio
              Reporter:
              dst Daniel Kristian Steffensen
              Peer reviewer:
              Carlos Escobedo
              Integrator:
              Andrew Nicols
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              23 Vote for this issue
              Watchers:
              29 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Jul/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 week, 2 days, 3 hours, 45 minutes
                  1w 2d 3h 45m