Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67728

Fix app selectors by doing it more specific

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Login at https://ci.moodle.org/
      2. Access https://ci.moodle.org/view/Testing/job/DEV.01 - Developer-requested Behat/)
      3. Navigate to Build with parameters
      4. Fill TAGS field with "@app"
      5. Check INSTALL_PLUGINAPP checkbox.
      6. Click on Build button.
      7. Click on the latest created job on the left of the screen.
      8. Check you are the starter.
      9. Wait the build to finish and check the log.
      10. Enter the console output
      11. Open the Section "Starting behat test run"
      12. Check that no scenario fails on step "When I enter the app".

      Note the behat tests can fail on other steps because they are still immature.

      Show
      Login at https://ci.moodle.org/ Access https://ci.moodle.org/view/Testing/job/DEV.01 - Developer-requested Behat/ ) Navigate to Build with parameters Fill TAGS field with "@app" Check INSTALL_PLUGINAPP checkbox. Click on Build button. Click on the latest created job on the left of the screen. Check you are the starter. Wait the build to finish and check the log. Enter the console output Open the Section "Starting behat test run" Check that no scenario fails on step "When I enter the app". Note the behat tests can fail on other steps because they are still immature.
    • Affected Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Pull 3.8 Branch:
    • Pull Master Branch:
      MDL-67728-master

      Description

      Right now the dom searches are done on the full HTML. It could get false positives. We should improve that selectors by selecting first the correct ancestors: First the modals and then the current page.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              pferre22 Pau Ferrer
              Reporter:
              pferre22 Pau Ferrer
              Peer reviewer:
              Juan Leyva
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Eloy Lafuente (stronk7)
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Mar/20

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 45 minutes
                  1d 45m